Skip to content

SCANPY-242 Improved releasability workflow#310

Merged
Seppli11 merged 1 commit into
masterfrom
MJ/SCANPY-242
Mar 24, 2026
Merged

SCANPY-242 Improved releasability workflow#310
Seppli11 merged 1 commit into
masterfrom
MJ/SCANPY-242

Conversation

@marc-jasper-sonarsource
Copy link
Copy Markdown
Contributor

No description provided.

@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod Bot commented Mar 24, 2026

SCANPY-242

@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha Bot commented Mar 24, 2026

Summary

Migrated releasability workflow from Cirrus CI check_suite trigger to GitHub's native workflow_run trigger, triggered by the Build workflow completion. Updated the releasability action from v2 to v3. The change simplifies the trigger condition from complex Cirrus CI checks to a straightforward workflow success check, while adding explicit branch filtering (master, branch-, dogfood-).

What reviewers should know

Review the trigger mechanism: Previously relied on external Cirrus CI webhooks, now uses GitHub's native workflow_run event from the Build workflow. The condition logic is significantly simpler — focus on whether github.event.workflow_run.conclusion == 'success' correctly captures when releasability checks should run. Verify the branch filters match the intended release branches. The action upgrade to v3 is straightforward; check the changelog if concerned about breaking changes.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

@sonarqube-next
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed for 'Python Scanner'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Copy Markdown
Contributor

@Seppli11 Seppli11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Seppli11 Seppli11 merged commit 33eb191 into master Mar 24, 2026
20 of 21 checks passed
@Seppli11 Seppli11 deleted the MJ/SCANPY-242 branch March 24, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants