SCANPY-246 SubmitReview: Use Vault token#316
Conversation
SummarySwitches the SubmitReview workflow to use a Vault-based GitHub token instead of GitHub's built-in secrets, bringing it into alignment with automation infrastructure changes and the RequestReview workflow. The GitHub token is now retrieved from Vault alongside the existing JIRA credentials, enabling centralized secret management. The What reviewers should knowFile to review: Key change: Line 24 switches the token source from What to verify:
|
There was a problem hiding this comment.
LGTM! ✅
Clean, minimal change that aligns SubmitReview with the established pattern in RequestReview.yml. The Vault path, variable names, and fromJSON extraction are identical between the two files, and removing pull-requests: read is correct — that permission only governs the built-in GitHub Actions token, which the Vault step doesn't use.
|





With the latest automation changes, we need the Vault-based token now. It's the same token as the one in RequestReview.yml file. Please take care of merging this, I have 200+ repos to update.