feat(rollback): RollbackExecutor and CLI execute path#28
Merged
Conversation
- RollbackExecutor: converts AsahiRollbackPlan into real subprocess calls. Non-mutating purity boundary is preserved in asahi_boot_chain.py; this module owns the execute boundary. - CLI: adds `sourceos-boot rollback plan` and `sourceos-boot rollback execute`. --execute flag required to shell out; dry-run default. - RollbackExecutionResult.to_dict() emits engineId + specVersion for traceability. - 28 tests passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rollback_executor.py): execute boundary forAsahiRollbackPlan. Shells out tonixos-rebuild switch --rollback. Dry-run by default. EmitsRollbackExecutionResultwithengineId, per-step results,durationMs, andissuedAt.sourceos-boot rollback plan(non-mutating) andsourceos-boot rollback execute(dry-run unless--execute).asahi_boot_chain.pyremains side-effect-free; all execution is inrollback_executor.py.Test plan
python3 -m pytest tests/ -q→ 28 passedsourceos-boot rollback plan→ printsAsahiRollbackPlanJSON, exits 0sourceos-boot rollback execute→ dry-run steps, exits 0sourceos-boot rollback execute --executeon device → applies rollback