feat(sync): add Katello content-view client and ContentViewSyncer#34
Merged
Conversation
katello_client.py: stdlib-only HTTP client (urllib.request) for Katello API; queries org, content view, lifecycle env, and version endpoints; returns a ContentViewManifest with the Pulp content URL and nix cache URL derived from the Foreman HTTPS port content_sync.py: ContentViewSyncer produces a non-mutating ContentSyncPlan (policy_gate: allowed/denied/no-op); execute() is the only side-effecting method and defaults to dry_run=True; enforces locus gate (local/trusted_private only); skips nix/nixos-rebuild if not in PATH cli.py: adds `sync plan` and `sync apply` subcommands under the `sync` area; --katello-url, --org, --content-view, --lifecycle-env, --locus, --flake-ref, --current-version, --no-verify-ssl, --execute flags 13 tests, all passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
katello_client.py: stdlib-only HTTP client for Katello API; queries org/content-view/lifecycle-env/version endpoints; derives Pulp content URL and nix cache URL from the Foreman base URLcontent_sync.py:ContentViewSyncerproduces a non-mutatingContentSyncPlan; locus gate (local/trusted_private only);execute()defaults to dry-run; skips missing nix/nixos-rebuild binaries gracefullycli.py: addssync planandsync applysubcommands;--executeflag required to leave dry-run modeUsage (Phase 0)
Test plan
pytest tests/test_katello_client.py)pytest)sourceos-syncd sync plan --helpshows all flagssync planreturns a ContentSyncPlan with correct nix_cache_url