-
Notifications
You must be signed in to change notification settings - Fork 33
SCS-0123-v2: Clarify mandatory service types #1093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 4 commits
90eb6fb
dd7917c
ded05b9
5ce40b0
c25b82b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,5 @@ supplements: | |
| We [implemented](https://github.com/SovereignCloudStack/standards/blob/main/Tests/iaas/openstack_test.py) | ||
| the following testcases in accordance with the standard: | ||
|
|
||
| - `scs-0123-service-X` (with varying `X`) ensures that a service of type X can be found in the service catalog, | ||
| - `scs-0123-storage-apis` ensures that a service of one of the following types can be found: "volume", "volumev3", "block-storage", | ||
| - `scs-0123-swift-s3` ensures that S3 can be used to access object storage using EC2 credentials from the identity API. | ||
| - `scs-0123-service-<service type>` ensures that a service with the given type can be found in the service catalog | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you must change the variable, please use a shorter one. I think
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll create a new supplement version along with the new standard version later. I think it's worth it if we indeed drop the s3 credentials test.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's actually not how this works. The supplement is supposed to cover all versions, except if the change is really massive. But that's not the case here. You can just add a parenthetical "only for v1" behind the one testcase. |
||
| - `scs-0123-storage-apis` ensures that a service of one of the following types can be found: "volume", "volumev3", "block-storage" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -269,6 +269,9 @@ scripts: | |
| - id: scs-0123-storage-apis | ||
| description: The block-storage API is discoverable as `volume`, `volumev3`, or `block-storage`. | ||
| url: https://docs.scs.community/standards/scs-0123-w1-mandatory-and-supported-IaaS-services-implementation#automated-tests | ||
| - id: scs-0123-service-s3 | ||
| description: s3 service is discoverable. | ||
| url: https://docs.scs.community/standards/scs-0123-w1-mandatory-and-supported-IaaS-services-implementation#automated-tests | ||
| - id: scs-0123-swift-s3 | ||
| description: The object-storage API is compatible with S3. | ||
| url: https://docs.scs.community/standards/scs-0123-w1-mandatory-and-supported-IaaS-services-implementation#automated-tests | ||
|
|
@@ -452,6 +455,18 @@ modules: | |
| - scs-0123-service-object-store | ||
| - scs-0123-storage-apis | ||
| - scs-0123-swift-s3 | ||
| - id: scs-0123-v2 | ||
| name: Mandatory and Supported IaaS Services | ||
| url: https://docs.scs.community/standards/scs-0123-v2-mandatory-and-supported-IaaS-services | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you shorten the slug (as I invited you to do), then this needs to be adjusted. |
||
| targets: | ||
| main: | ||
| - scs-0123-service-compute | ||
| - scs-0123-service-identity | ||
| - scs-0123-service-image | ||
| - scs-0123-service-network | ||
| - scs-0123-service-load-balancer | ||
| - scs-0123-storage-apis | ||
| - scs-0123-service-s3 | ||
| - id: scs-0302-v1 | ||
| name: Domain Manager Role | ||
| url: https://docs.scs.community/standards/scs-0302-v1-domain-manager-role | ||
|
|
@@ -496,7 +511,7 @@ versions: | |
| - scs-0116-v1 | ||
| - scs-0117-v1 | ||
| - scs-0121-v1 | ||
| - scs-0123-v1 | ||
| - scs-0123-v2 | ||
| - scs-0302-v1 | ||
| - version: v5.1 # copy of v5, but with include "scs-0123-v1", which had simply been forgotten | ||
| stabilized_at: 2024-12-19 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file needs to be saved under a different name:
Standards/scs-0123-v2-mandatory-and-supported-iaas-services.md(importantly, withv2). Feel free to shorten the slug, though!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I had the notice in the commit message, but it didn't make it to the PR description - I did not create a new file for now to keep the diff easier to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. Not the worst move, to be honest :)