Skip to content

chore: update response for check org api#18

Merged
ngovinh2k2 merged 1 commit into
devfrom
chore/update-response-for-check-org-api
Apr 13, 2026
Merged

chore: update response for check org api#18
ngovinh2k2 merged 1 commit into
devfrom
chore/update-response-for-check-org-api

Conversation

@ngovinh2k2
Copy link
Copy Markdown
Member

What?

Update response for check organization API

Why?

How?

Testing?

  • Functional Testing
  • Security
  • Performance
  • Error Handling
  • Code Quality
  • Documentation
  • Database
  • Deployment
  • Final Review

Anything Else?

@ngovinh2k2 ngovinh2k2 merged commit 210af11 into dev Apr 13, 2026
1 check passed
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the organization view to include a 'template' field in the API response. However, a critical issue was identified as the 'Organization' model does not appear to have a 'template' attribute, which will result in a runtime AttributeError and a 500 error.


return Response({"result": result}, status=status.HTTP_200_OK)
return Response(
{"result": result, "template": organization.template},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Organization model does not have a template field. Accessing organization.template will raise an AttributeError at runtime, causing the API to return a 500 error. Please verify the intended field name or ensure the model is updated to include this attribute.

@ngovinh2k2 ngovinh2k2 deleted the chore/update-response-for-check-org-api branch May 22, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant