Template.create, Template.update, Template.delete#50
Open
begedin wants to merge 4 commits into
Open
Conversation
Contributor
|
Hey @begedin - thanks for the PR! Will review asap. |
|
@ewandennis any progress on this at all? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Template.create, .update and .delete
To enable this support, while following existing conventions as much as I could, I also had to define
%Template{}and%Template.Response{}structs.This PR still doesn't add support for
Template.get/retrieveorTemplate.listSince
Template.deleteseems to be the first supported endpoint which returns a200with a blank map as the response body, I extended support for automated body results decoding by checking if the decoded body has a results key.I'm aware that there's the
decode_resultsoption I could've used, but that seems only specific and not very clean. If it's preferable for me to use that, I can update the PR.