add initial attempt for fixing parameters and broadcasting#73
Open
Transurgeon wants to merge 11 commits intoparameter-support-v2from
Open
add initial attempt for fixing parameters and broadcasting#73Transurgeon wants to merge 11 commits intoparameter-support-v2from
Transurgeon wants to merge 11 commits intoparameter-support-v2from
Conversation
Collaborator
Author
|
@dance858 is this similar to what you had in mind for this issue? but I wonder if we could make it more general to any branch or something. |
Transurgeon
commented
Apr 9, 2026
Transurgeon
commented
Apr 9, 2026
dance858
reviewed
Apr 9, 2026
dance858
reviewed
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds minimal changes to support
broadcast(parameter).More generally, I think this will also allow constant parameters to appear as the
param_sourcefor the three bivariate atoms we have.To clarify the language, by constant parameters I mean any arbitrary expression involving cp.parameters (or cp.constants)
which also satisfies the
.is_constant()attribute in Python.This means that we will form an matmul/multiply node where the param_source is a tree rather than a single node.
The fix is to simply call forward on the param_source expression and then use it's values for the bivariate atom.