Skip to content

Fix typo when searching pools#1433

Closed
luis-c-matos-alb wants to merge 7 commits into
SpriteLink:masterfrom
AlticeLabsPublic:master
Closed

Fix typo when searching pools#1433
luis-c-matos-alb wants to merge 7 commits into
SpriteLink:masterfrom
AlticeLabsPublic:master

Conversation

@luis-c-matos-alb
Copy link
Copy Markdown
Contributor

No description provided.

@plajjan
Copy link
Copy Markdown
Member

plajjan commented May 8, 2025

@luis-c-matos-alb can you strip out the extraneous commits from this PR? I think that initial commit to fix the backend.py looks correct but the rest is automatic noise?

@garberg should there be a test that covers this? I guess we can merge in the meantime since the fix looks obvious

@luis-c-matos-alb
Copy link
Copy Markdown
Contributor Author

@luis-c-matos-alb can you strip out the extraneous commits from this PR? I think that initial commit to fix the backend.py looks correct but the rest is automatic noise?

@garberg should there be a test that covers this? I guess we can merge in the meantime since the fix looks obvious

I'll open another PR without using the forked project.

@luis-c-matos-alb
Copy link
Copy Markdown
Contributor Author

New pullRequest #1434

@garberg
Copy link
Copy Markdown
Member

garberg commented May 9, 2025

@luis-c-matos-alb can you strip out the extraneous commits from this PR? I think that initial commit to fix the backend.py looks correct but the rest is automatic noise?

@garberg should there be a test that covers this? I guess we can merge in the meantime since the fix looks obvious

Agreed, we can fix the test later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants