Skip to content

chore: enable mypy disallow_untyped_defs for stackvox/ #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuBehan merged 1 commit into from
Apr 30, 2026
Merged

chore: enable mypy disallow_untyped_defs for stackvox/ #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,15 +106,17 @@ warn_redundant_casts = true
warn_return_any = true
check_untyped_defs = true
no_implicit_optional = true
disallow_untyped_defs = true

[[tool.mypy.overrides]]
# Third-party deps without inline type stubs.
module = ["kokoro_onnx", "sounddevice", "soundfile"]
ignore_missing_imports = true

[[tool.mypy.overrides]]
# Tests use pytest-mock's mocker.patch which returns Any-heavy values; don't
# require full strictness there.
# Tests rely on pytest-mock's `mocker` (Any-heavy) and pytest fixtures with
# implicit Any-typed kwargs. Strict untyped-def bans buy little here, so
# tests stay on the looser config.
module = "tests.*"
disallow_untyped_defs = false

Expand Down
5 changes: 4 additions & 1 deletion stackvox/daemon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,10 @@ def _read_default_device() -> int:

last_device = [_read_default_device()]

def _on_device_change(obj_id: int, n: int, addrs, data) -> int:
def _on_device_change(obj_id: int, n: int, addrs: Any, data: Any) -> int:
# `addrs` is a ctypes.POINTER(_PropAddr); `data` is a c_void_p — neither
# is needed because we already know which property fired (only one is
# registered) and we re-read the device ID directly.
try:
current = _read_default_device()
if current and current != last_device[0]:
Expand Down