Skip to content

fix(audio): mute toggle works on mobile (pause instead of setVolume) #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sacha-l wants to merge 1 commit into from
Closed

fix(audio): mute toggle works on mobile (pause instead of setVolume) #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions client/src/components/audio/sound-cloud-audio.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,16 @@ export function SoundCloudAudioProvider({ children }: { children: React.ReactNod
const next = !prev;
const widget = widgetRef.current;
if (widget) {
widget.setVolume(next ? 0 : 100);
widget.play();
// Mute by pausing, not by setVolume(0): on mobile (notably iOS) volume is
// hardware-controlled and setVolume is a no-op, so volume-based muting
// silently failed there. play()/pause() honor the user's tap on every
// platform — and the tap is the gesture mobile needs to start audio.
if (next) {
widget.pause();
} else {
widget.setVolume(100);
widget.play();
}
}
return next;
});
Expand Down