Minor bug fixes#168
Draft
sacha-l wants to merge 5 commits into
Draft
Conversation
The mute toggle relied on widget.setVolume(0), but volume is hardware-controlled on mobile (notably iOS) where setVolume is a no-op — so tapping mute kept playing at full volume. Mute now pauses and unmute plays (setVolume(100) on desktop); play/pause honor the user's tap on every platform.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
Editable add/remove lists keyed their controlled inputs by array index, so deleting a middle row reused the wrong DOM node and shifted focus/values onto a sibling. Give each row a stable client-generated id (kept length-synced with the data) and key by it. Also fold the index into TeamPaymentSection's read-only member key: a wallet address is not unique across members (mock data redacts several to one string), so keying by address alone collided and tripped React's duplicate-key warning.
project.controller used raw console.log for the updateProject payload preview and the M2-agreement confirmation; route them through the existing logger util (info/success) like the rest of the controller.
…am pages The landing page now shows only the hero, live stats, and program cards (heading "Explore past programs"); the featured unit and the projects filter/grid are gone. The search view (search box, WINNERS/ALL toggle, category filters, grid + detail modal) is extracted into a reusable ProjectExplorer and rendered on each program's detail page, scoped to that program's entries.
The Programs page open section was labelled "Grid"; relabel it "Ongoing programs" to match the page's intent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolling draft for small bug fixes.
Fixes
Audio mute on mobile — the mute toggle relied on
widget.setVolume(0), which is a no-op on mobile (iOS controls volume in hardware), so tapping mute kept playing at full volume. Mute now pauses / unmute plays (setVolume(100)still applied on desktop). Needs a real-device check.Stable React keys on editable team + M2-agreement lists — the add/remove lists in
TeamPaymentSection(editable members),UpdateTeamModal, andM2AgreementModal(core features / documentation / nice-to-have) keyed their controlled inputs by array index, so deleting a middle row reused the wrong DOM node and shifted focus/values onto a sibling row. Each row now carries a stable client-generated id (kept length-synced with its data) and is keyed by it.TeamPaymentSection duplicate-key warning — the read-only member card keyed by
member.walletAddress || index. Wallet addresses are not unique across a team's members (mock data redacts several to one string), so keying by address alone collided and tripped React's "two children with the same key" warning. The key now folds in the index.Two debug
console.log-> logger (server) —project.controller.jsused rawconsole.logfor theupdateProjectpayload preview and the M2-agreement confirmation; both now route through the existingloggerutil (info/success) like the rest of the controller.Landing page shows programs only — removed the "Now Showing" featured unit and the whole project search/filter/grid from the landing page (
HomePage.tsx). It now shows the hero, live stats, and the program cards, with the section heading reworded to "Explore past programs".Project search view moved onto program pages — the landing search view (search box, WINNERS/ALL toggle, category-filter sheet, grid + detail modal) is extracted into a reusable
ProjectExplorercomponent. Each program's detail page (ProgramDetailPage.tsx) now renders it in place of the old static grid, scoped to that program's entries, so opening a program (e.g. sub0 hack 2025) gives the same browse/search experience."Ongoing programs" heading — the Programs page open section was labelled
·GRID; renamed to·ONGOING PROGRAMS(ProgramsPage.tsx).Out of scope (config, not code)
POST /api/admin/session) which enforcesparsed.domain === EXPECTED_DOMAIN(auth.middleware.js). Fix operationally: setEXPECTED_DOMAINon Railway to the exact production hostname (orDISABLE_SIWS_DOMAIN_CHECK=true). Already flagged indocs/launch-checklist.md.Test plan / report
cd server && npm test— 293/293 passingcd client && npm run build— clean (tsc + vite)cd client && npm run lint— clean (--max-warnings 0)stadium-tester — preview (mock mode), re-run for the landing/program changes
stadium-git-fix-minor-bug-fixespreview · commit79ccc0d·window.__STADIUM_MOCK__ = true· 0 console errors · 5 scenarios: 5 pass, 0 fail/runs in mock mode__STADIUM_MOCK__ === true/surfaces programs onlysearch entries…input, no·DIRECTORY / GRID/programsheading is "Ongoing programs", not "Grid"·ONGOING PROGRAMSvisible;·GRIDcount 0/m2-program, renders, 0 errors/programs/symbiosis-2025:search entries…+ WINNERS/ALL +·PROJECTSrender; 73 cards, non-matching query narrows to 0 (search functional)Caveats:
VITE_USE_TEST_WALLET=truebuild. The key-stability fix is covered by the green typecheck + diff.Owner TODO (needs hardware / harness):
VITE_USE_TEST_WALLET=truebuild to exercise focus retentionDraft -> develop.