style(chunking_utils): rename overlap_tokens to overlap_size#376
Open
luojiyin1987 wants to merge 1 commit into
Open
style(chunking_utils): rename overlap_tokens to overlap_size#376luojiyin1987 wants to merge 1 commit into
luojiyin1987 wants to merge 1 commit into
Conversation
The parameter name was misleading — in traditional mode it represents tokens, but in AST mode callers pass a character count. overlay_size avoids the confusion without changing the code's math.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter name
overlap_tokenswas misleading —calculate_safe_chunk_size()is called withchunk_overlapwhich represents tokens in traditional mode but characters in AST mode. Renaming tooverlap_sizeavoids the semantic confusion.No behavioural change — all callers pass by position.