Add E2E Tests for Alerts and Incidents Flows#779
Open
Johnpii1 wants to merge 2 commits into
Open
Conversation
…d-incidents test: add e2e tests for alerts and incidents flows
|
@Johnpii1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Description
Add mocked incident fixtures and route handlers to e2e/utils/mockApi.ts to support /api/v1/incidents listing, filtering, and /:id/read acknowledgement.
Add Playwright page objects e2e/pages/AlertsPage.ts and e2e/pages/IncidentsPage.ts to encapsulate interactions for alerts and incident heatmap.
Add E2E spec e2e/tests/alerts-incidents.spec.ts that covers alert listing, severity/status/search filters, bulk triage actions (mark-read/dismiss), and incident heatmap cell assertions.
Closes #725.
Type of Change
Related Issue
Closes #725
Changes Made
Testing
Testing
Built the frontend with npm --workspace=frontend run build which completed successfully.
Ran npm run test:e2e -- --project=chromium e2e/tests/alerts-incidents.spec.ts but the Playwright browser executable was not present so the tests failed to launch (error: missing Chromium executable).
Attempted npx playwright install chromium firefox to install browsers but the download failed (Playwright CDN returned 403 Forbidden), blocking E2E test execution.
npm run test:unit)npm run test:integration)Manual test steps (if applicable):
Migration Changes
npm run migrate:makenpm run migrate:validatedown()function tested locallyDocumentation
README.mdupdated (new commands, endpoints, or setup steps)docs/file updated.env.exampleupdated (new environment variables)backend/docs/API.mdupdated (new or changed endpoints)Checklist
maintype(scope): summary)npm run lint,cargo clippy)npm run build,cargo build --release)console.log/println!left in production code.envfiles committedCI Status
Screenshots
Breaking Changes
Additional Notes