feat(invoice): add guarded recipient substitution with co-signer approval#255
Open
johnsaviour56-ship-it wants to merge 4 commits into
Open
Conversation
|
@johnsaviour56-ship-it Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a secure recipient substitution flow, allowing a recipient address to be replaced after invoice creation while preserving existing allocations. For invoices with co-signers, substitutions require a fresh round of approvals to prevent unauthorized recipient changes.
Changes
substitute_recipient()to support replacing an existing recipient with a new address.required_signaturesthreshold.Testing
Added coverage for:
Acceptance Criteria
"recipient not found"cargo clippypasses with zero warningsResult
Recipient addresses can now be safely updated without recreating invoices, while maintaining strong authorization guarantees through a dedicated approval workflow and preserving all recipient-related state.
Closes #226