feat: implement portfolio alerts & notifications#449
Open
AbuJulaybeeb wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrated the event-driven alert system under the src/alerts module.
Added core functionality for tracking price alerts (createPriceAlert) and portfolio milestones (createPortfolioAlert).
Implemented delivery channel configurations (Email, Webhook, In-App) via the alert_preferences entity and dispatcher logic.
Included management logic allowing users to toggle specific alerts and configure cooldown frequencies to prevent spam.
Integrated the alert_trigger_log to maintain historical tracking and systemic auditing.
Why it was done:
To proactively inform users about critical portfolio events such as significant price action, allocation drift, and target milestones, ensuring real-time responsiveness to market conditions.
How it was verified:
Verified core condition evaluation, threshold triggers, and cooldown mechanisms via unit tests (alerts.service.spec.ts).
Note: Integration and E2E tests for the broader notification delivery pipeline are pending a separate test-suite expansion, but unit coverage verifies the strict mathematical condition logic.
closes #331