fix(queue): enforce hard backpressure on bounded queues#533
Open
Babigdk wants to merge 1 commit into
Open
Conversation
|
@Babigdk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements bounded-memory backpressure controls for stream ingestion queues.
The existing queue already enforced a capacity limit, but non-critical packets were dropped immediately when the queue became full. This change applies hard producer-side backpressure so upstream ingestion blocks until downstream consumers free capacity, preventing uncontrolled memory growth during sink lag events.
Related Issue
Closes #487
Changes Made
1000Backpressure Behavior
Before:
After:
Acceptance Criteria
Testing
Validation performed via code review of queue flow:
queue.put(...)Notes for Reviewers
The repository issue references a Python implementation using
janus.Queue(maxsize=1000), but the current codebase implements equivalent functionality in TypeScript viaAsyncBoundedQueue. This PR applies the requested bounded-memory backpressure behavior to the TypeScript implementation.