Fix config assets and payment rate limiting#61
Merged
Manuel1234477 merged 2 commits intoJun 26, 2026
Conversation
|
I'd like to work on this. Approach:
Estimated effort: ~1-2 hours. PR incoming shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
accepted_assetsinstead of the removedusdc_issuerconfig field.Config's manualDebugimplementation so secrets remain redacted.RATE_LIMIT_REQUESTS_PER_SECconfig support and wire rate limiting forPOST /payments.ConnectInfofor real client IPs, withx-forwarded-for/x-real-ipas fallback.429 rate_limit_exceeded.Validation
cargo checkcargo testNotes
Cargo.lockwas updated to includegovernorand its transitive dependencies, matching the existingCargo.tomldependency.Merge Update
upstream/maininto this branch.RateLimitStatescoped to the routerPOST /paymentsonlyConnectInfoIP first, thenx-forwarded-for/x-real-ipfallback