Hotfix A: remove Hide; add desktop header navigation#9
Merged
Conversation
Live testing showed two problems: 1. Hide was a footgun — one tap made a container vanish with recovery buried in Settings, and an update could be lost. Remove it entirely: the Hide button, the Settings "Hidden containers" section, the /api/hide(/:name) + /api/hidden routes, the hidden table + db functions, the isHidden wiring, and the `hidden` item field. Previously-hidden containers reappear automatically (nothing filters them now). 2. The nav bar is mobile-only (bottom nav hidden >=768px) and the header had no nav links, so on a desktop browser there was no way to reach Settings/History. Add Updates/History/Settings links to the header, shown >=768px, complementing the mobile bottom nav. Server tests 64/64; client builds clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues from live testing.
1. Remove Hide (footgun)
Hide made a container vanish in one tap, recovery was buried in Settings, and an update could be lost. Removed entirely:
POST /api/hide,DELETE /api/hide/:name,GET /api/hiddenhiddentable + db functions, theisHiddenwiring, thehiddenitem fieldPreviously-hidden containers reappear automatically once deployed — nothing filters them anymore (this recovers the container the user accidentally hid).
2. Desktop navigation was unreachable
The nav bar is mobile-only (
.bottom-navisdisplay:none≥768px) andHeader.jsxhad no links, so on a desktop browser there was no way to reach Settings/History. Added Updates / History / Settings links to the header, shown ≥768px, complementing the mobile bottom nav.Test plan
cd server && node --test→ 64/64cd client && npm run build→ cleanGenerated by Claude Code