support changing entrypoint in skipper#191
Open
tomerschwartz24 wants to merge 3 commits into
Open
Conversation
tomerschwartz24
force-pushed
the
tomer/support-changing-entrypoint
branch
2 times, most recently
from
e4784e4 to
d7d6d4d
Compare
Add optional `entrypoint` field to skipper.yaml. When set, it overrides the default /opt/skipper/skipper-entrypoint.sh.
- Replace pkg_resources (removed in Python 3.14) with importlib equivalents in cli.py and utils.py - Fix build CI job to install from local checkout instead of PyPI - Update test mocks: pkg_resources.resource_filename -> skipper.utils.get_extra_file - Fix test_version mock for importlib.metadata.version() string return - Add test_completion for coverage
tomerschwartz24
force-pushed
the
tomer/support-changing-entrypoint
branch
from
d7d6d4d to
7298e32
Compare
tomerschwartz24
requested review from
Harelfel,
khizunov,
roeigo-stratoscale and
simba1997
Use try/except fallbacks to support older Python versions: - importlib.metadata (added in 3.8) -> importlib_metadata backport - importlib.resources.files (added in 3.9) -> importlib_resources backport Add conditional dependencies in pyproject.toml. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
tomerschwartz24
requested review from
Harelfel,
khizunov,
roeigo-stratoscale and
simba1997
and removed request for
Harelfel,
khizunov,
roeigo-stratoscale and
simba1997
roeigo-stratoscale
left a comment
roeigo-stratoscale
left a comment
There was a problem hiding this comment.
Making sure this is on top of skipper 2 branch?
| - name: Install dependencies | ||
| run: | | ||
| pip install --user strato-skipper | ||
| pip install --user . |
| "setuptools", | ||
| "pbr" | ||
| "pbr", | ||
| "importlib_metadata; python_version < '3.8'", |
There was a problem hiding this comment.
how come we rely on different python versions?
roeigo-stratoscale
approved these changes
Apr 29, 2026
yuvalta
reviewed
May 5, 2026
| @@ -34,7 +34,9 @@ dependencies = [ | |||
| "requests-bearer==0.5.1", | |||
| "retry", | |||
| "setuptools", | |||
There was a problem hiding this comment.
@tomerschwartz24 I think we need to freeze this -
https://setuptools.pypa.io/en/latest/history.html#deprecations-and-removals
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.