Repository navigation
Sync with upstream patchright (through v1.61.1) - #7
Open
StudentWan wants to merge 23 commits into
Open
StudentWan wants to merge 23 commits into
StudentWan wants to merge 23 commits into
Conversation
…nyzu#199) * chore: scaffold fix-v1.60.0-25698100548 * Port to v1.60.0 Note: Might revert some test skips later * Resolve Review * Revert Regressions --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Vinyzu <50874994+Vinyzu@users.noreply.github.com>
Co-authored-by: Sulthon Zainul Habib <4921059+sulthonzh@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…cessary context initialization
…ods in JSHandle class and remove unnecessary context initialization
…nyzu#216) Co-authored-by: Vinyzu <50874994+Vinyzu@users.noreply.github.com> Co-authored-by: Federico Pomar <1781508+fmpomar@users.noreply.github.com>
…nyzu#219) Co-authored-by: Vinyzu <50874994+Vinyzu@users.noreply.github.com>
…rmatting, improve test workflows (Kaliiiiiiiiii-Vinyzu#222)
Sync with Kaliiiiiiiiii-Vinyzu/patchright (22 commits, through v1.61.1 fixes, JSHandle refactor, visibility checks, and the Kaliiiiiiiiii-Vinyzu#222 driver refactor/formatting). Conflict in patchright.patch resolved by taking upstream's side. That file is a generated documentation artifact (regenerated by .github/workflows/patch_file_updater.yml) and is not used to patch the driver. The Edge NTP crash fix remains intact in driver_patches/crNetworkManagerPatch.ts, which merged cleanly. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
StudentWan
had a problem deploying
to
pr-artifact-build
July 29, 2026 03:55 — with 
GitHub Actions
Failure
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges 22 commits from
Kaliiiiiiiiii-Vinyzu/patchrightinto our fork.What's coming in
evaluateExpressionrefactorbuildPatch.ts,credentialsPatch.ts,networkPatch.tsexpectUtilsPatch.tsOur fork's delta
Against the merge base, our only remaining divergence was the Edge NTP crash fix (9 lines). It merged cleanly and is intact at
driver_patches/crNetworkManagerPatch.ts:575-583. The earlier js-handle and expose_binding fixes are no longer part of our delta — absorbed upstream or reverted by 699c377.Conflict resolution
One conflict, in
patchright.patch, resolved by taking upstream's side.That file is a generated documentation artifact — its own first line says it "is not used, it is only for documentation", and
.github/workflows/patch_file_updater.ymlregenerates it wholesale viadiff -ruN playwright patchright. The conflict came from upstream's Kaliiiiiiiiii-Vinyzu#222 reformat (41,063 insertions / 6,575 deletions to that file alone) colliding with our 9-line insert. Hand-resolving it would be overwritten by the next CI patch run.Not yet verified
npm run typecheckandnpm run patchhave not been run on this merge.npm run patchis the meaningful gate — our patches usets-morphgetMethodOrThrow/getClassOrThrow, which throw at patch time if upstream's refactor moved anything they reach for.Worth a look during review
Our NTP early-return sits before the
if (event.resourceType !== 'Document') return;guard, whereas upstream's reformatted version puts that guard first. The merge preserved our ordering, so behavior is unchanged — but it means everyntp.msnrequest gets an explicitFetch.continueRequest, including subresources, not just Documents.🤖 Generated with Claude Code