Updated codeclimate#102
Merged
Merged
Conversation
This was referenced Jan 4, 2021
Member
|
Alright, let's ⛵ |
Member
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I tried to upgrade the codeclimate plugin in qltysh-archive/SublimeLinter-contrib-codeclimate#3. Since there is no response by the original developers, I will overtake the responsibility for this plugin now.
Further, I decided to restrict the platforms toosx, andlinuxsince the plugin's implementation is optimized with the application on these two platforms. I see some possibilities also to include support forwindowsin some further releases. However, this highly depends on what codeclimate will do with it's CLI and needs some serious testing and maybe some workarounds before.I just realized that most installations at Package Control are from Windows Users. The statistics say WIN 2K, Mac 539, Linux 205 users. I didn't test against Windows, but because "Package Control" shows this clear picture, I suggest removing the platform restriction for my replacement because it is closely following the original implementation.