[Refactor:Developer] Rewrite CMake config and install script#17
Open
williamjallen wants to merge 3 commits intomainfrom
Open
[Refactor:Developer] Rewrite CMake config and install script#17williamjallen wants to merge 3 commits intomainfrom
williamjallen wants to merge 3 commits intomainfrom
Conversation
Member
Author
|
@bmcutler It looks like I don't have merge access in this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
submitty_installcurrently spends a disproportionate amount of time installing AnalysisToolsTS. The build is not cached, so the entire thing has to be built each time, even if there are no changes to AnalysisToolsTS.What is the new behavior?
The tree-sitter dependencies are now managed by CMake, leading to much faster
submitty_installruntimes. As part of this work, I also pinned each of the dependencies, which prevents our build from breaking if upstream breaks their build. I also cleaned up the CI since it was very broken.