Refactor SunKit's Sun - #58

Closed

Sireikis wants to merge 91 commits into

SunKit-Swift:mainfrom

Sireikis:story/refactor-sun

Commits on Aug 28, 2025

Fixed formatting and style in Utils

Ignas Sireikis
authored and
Ignas Sireikis
committed
Fixed formatting and style in SunElevationEvents and Utils.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Fixed formatting and style in Sun.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Fixed formatting and style in HorizonCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Fixed formatting and style in HMS.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Fixed formatting and style in Extensions.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Fixed formatting and style in EquatorialCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Fixed formatting and style in EclipticCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Fixed formatting and style in DMS.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Fixed formatting and style in Angle.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Fixed formatting and style in UT_DMS.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Fixed formatting and style in UT_EclipticCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Fixed formatting and style in UT_EquatorialCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Fixed formatting and style in UT_HMS.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Fixed formatting and style in UT_HorizonCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Fixed formatting and style in UT_Sun.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Fixed formatting and style in UT_Utils. Completed first pass refactoring.

Ignas Sireikis
authored and
Ignas Sireikis
committed

Commits on Sep 19, 2025

Added sun folder.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Created debugging utils file. Moved functions.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Code cleanup.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Removed or shortened redundant comments.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Applied consistent horizontal spacing style.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Applied consistent vertical spacing style.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Reorganized the order of sun event variables to be chronological.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Cleaned up comments for computed sun event variables.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Reorganized order of variables in refresh function.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Reorganized order of get functions used in refresh to match order of appearance.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Moved debugging utils into extension folder.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Moved equatable comformance into extension folder.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Moved hashable comformance into extension folder.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted sun horizon coordinate calculation as nested function.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted sun equatorial coordinates calculation as nested function.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted sun ecliptic coordinates calculation as nested function.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Added todo comment.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Parameterized calculateSunEclipticCoordinates function. Extracted nested function.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Parameterized calculateSunEquatorialCoordinates function. Extracted nested function.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Parameterized calculateSunHorizonCoordinates function. Added comment to refactor EquatorialCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Made horizontal spacing consistent.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Removed redundant comments.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted calculateHorizonCoordinates function.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Added tracking to missing file.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Added initial folder.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Tracked missing files.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Created SunCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Created private backing variable for sun coordinate related properties.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted function calculateSunEclipticLongitude.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted calculateLSTDecimal function.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Moved function closer to use.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Deleted unused function.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Added section marks.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted variables from month events.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted calculateCosineofSolarHourAngle function.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted clampCosineOfSolarHourAngle function.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted calculateSunriseSolarHourAngle function.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted calculateSunsetSolarHourAngle function.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Slide variable closer to site of use.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted calculateSeconds function.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted calculateUTCMinutes function.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted calculateSunriseSeconds function.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted calculateSunsetSeconds function.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted calculateDate function.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Moved additional code into calculate seconds functions.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Added TODO.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Created extension folder. Move date strideable extension into folder.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Moved Calendar extension into folder.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Renamed and moved file.

Ignas Sireikis
authored and
Ignas Sireikis
committed

Commits on Sep 21, 2025

Added methods to SunCoordinates in preparation for sun methods refactor.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Made code style in EclipticCoordinates consistent.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Reorganized EquatorialCoordinates methods to follow a high to low level concept organization.

Ignas Sireikis
authored and
Ignas Sireikis
committed

Commits on Sep 22, 2025

Moved sun constant sunEclipticLongitudePerigee into SunCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Moved sun constant sunEclipticLongitudeAtTheEpoch into SunCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Moved function getSunMeanAnomaly into SunCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Moved function calculateSunEclipticLongitude into SunCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Adjust privacy level in SunCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Parameterized function calculateLSTDecimal and moved it into SunCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Moved getSunHorizonCoordinatesFrom function closer to where it's used.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted updateCoordinates method.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Parameterized updateSunCoordinates method.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Moved calculateSunEclipticCoordinates into SunCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Moved calculateSunEquatorialCoordinates into SunCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted nested function calculateSunHorizonCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Updated getSunHorizonCoordinatesFrom to use extracted calculateSunHorizonCoordinates function.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted calculateSunHorizonCoordinates into SunCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Renamed function in SunCoordinates. Uncommented implementation of setSunHorizonCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Replaced duplicated code in getSunHorizonCoordinatesFrom with getSunHorizonCoordinates in SunCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted function getSunHorizonCoordinates into SunCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Adjusted privacy levels in SunCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Changed the coordinate variables to be backed by the SunCoordinates object. Now using the setCoordinates method on SunCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Extracted setSunCoordinates function into SunCoordinates.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Removed TODO comment.

Ignas Sireikis
authored and
Ignas Sireikis
committed
Removed TODO comment.

Ignas Sireikis
authored and
Ignas Sireikis
committed