Repository navigation
fix(pack): fetch a GitHub release asset with curl when tinyhttps cannot read GitHub's long header line - #70
Merged
Conversation
…etched with curl GitHub's redirect for a release asset now carries a 9.2 KB content-security-policy line; tinyhttps 0.3 gives up on header lines over 8 KB, so every payload job of the 0.0.17 Release run failed to fetch the engine. On that error the file is downloaded with curl and verified against the lock as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.0.17 Release run (40022574908) failed in every payload job: GitHub's 302 for a release download now carries a 9243-byte
content-security-policyheader line, and tinyhttps 0.3 (packaging only; the server does not use it) gives up on header lines over 8192 bytes (Incomplete headers: line exceeds 8192 bytes without a CRLF). PR CI never downloaded: its payload cache had the archives.On that one error,
pack::fetchdownloads the file with curl (on every runner) and verifies it against the lock exactly as before (sha256, size). Reproduced locally with an empty cache: the fallback fetchedclangd-23.1.0-mcppls.5-linux-x64.tar.gzand the part assembled. The real fix belongs in tinyhttps (a longer line limit); remove this when it has one.🤖 Generated with Claude Code