Skip to content

[UPMERGE] 1.1 -> 1.2 #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SyliusBot wants to merge 3 commits into from
+11 −0
Closed

[UPMERGE] 1.1 -> 1.2 #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5da5d63
FIX: [Shop] #115 fix slug route requirement to support nested page slugs
crydotsnake May 9, 2026
806540c
behat: add test case
crydotsnake May 13, 2026
62ceef6
FIX: [Shop] #115 fix slug route requirement to support nested page sl…
TheMilek May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/routes/shop/page.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ sylius_cms_shop_page_show:
methods: [GET]
defaults:
_controller: sylius_cms.controller.page.overriden::showAction
requirements:
slug: .+(?<!/)

sylius_cms_shop_collections_page_index:
path: /collections/{code}/pages
Expand Down
9 changes: 9 additions & 0 deletions features/shop/displaying_page.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,12 @@ Feature: Displaying pages
And this page also has "title" slug
When I go to this page
Then I should see page title "United States"

@ui
Scenario: Displaying page with a nested slug containing a slash
Given there is a page in the store
And this page has "Article one" name
And this page also has "Article one" title
And this page also has "articles/article1" slug
When I go to the "articles/article1" page
Then I should see a page with "Article one" name
Loading