[BootstrapAdminUI] Expose as ux bundle #362
Draft
Jibbarth wants to merge 5 commits intoSylius:mainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 👋
This is a draft/Poc to expose the BootstrapAdminUi as an Ux bundle, to let the app using asset-mapper/importmap importing dependencies.
It helps me to review symfony/symfony-docs#21292
It could fix #200. I tested to add a custom controller in assets/controllers and referencing it inside a template works well directly.
The scss to css move has been made by an AI, and it kinda work, except for the dark theme. But the toggler works :)
The benefits of this solution is that we do no longer have to build assets for bootstrap-admin-ui and version them in the public folder. It will be the final app that build things.
Let me know if there is any interests on this, to continue works.
We could at the end have a assetmapper config, beside to a webpack-encore config for users who prefer it.