Skip to content

Submit endpoint4#1050

Merged
danielfang97 merged 21 commits into
mainfrom
submitEndpoint4
Jul 24, 2026
Merged

Submit endpoint4#1050
danielfang97 merged 21 commits into
mainfrom
submitEndpoint4

Conversation

@danielfang97

Copy link
Copy Markdown
Contributor

This is the branch for just submit

@danielfang97
danielfang97 requested a review from cjmyers July 14, 2026 16:17

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file for?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for helping with submit plugins. The plugin needs access to the file that it is trying to convert. So, this gives the plugin a link to download the file. After it's downloaded, SynBioHub deletes the link.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is a DownloadService part of submit?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for SBOLTestRunner.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this file?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was a result of a merge conflict when adding the sboltestrunner branch to this branch. All it is changing is one word in the response entity from ? to String. It is returning String but it's defined now.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this file?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is linked to the Expose Controller. It helps out with giving the plugin a download link to download the file.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this file?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a bug in the sboltestrunner where prefixes were being deleted or being labeled as ns: instead of like sbh:. So, this checks for prefixes and makes sure they're being labeled correctly to match

@danielfang97
danielfang97 merged commit 089b3a2 into main Jul 24, 2026
6 checks passed
@danielfang97
danielfang97 deleted the submitEndpoint4 branch July 24, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants