fix: v1.9.13 — complete ffmpeg path resolution (23 bare subprocess calls)

SysAdminDoc · SysAdminDoc · commit c09519294dd2 · 2026-03-27T18:36:13.000-04:00
Every subprocess call that invoked "ffmpeg" as a bare string now uses
get_ffmpeg_path() for bundled install compatibility:

Routes (13 fixes):
- audio.py: waveform extraction
- system.py: ffmpeg version check
- timeline.py: marker export
- video_core.py: 7 calls (concat, merge, trim, pip, preview-frame, stabilize)
- video_editing.py: 3 calls (reframe, cropdetect, face-reframe audio merge)

Core modules (10 fixes):
- audio.py: 2 PCM extraction calls
- audio_suite.py: 2 loudness/waveform calls
- highlights.py: frame extraction for vision
- loudness_match.py: 4 loudnorm measure/normalize calls
- scene_detect.py: threshold detection

Combined with batch 37 (14 ffprobe) and batch 39 (3 ffprobe): the entire
codebase now resolves ffmpeg/ffprobe via cached path helpers.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Changelog
 
+## [1.9.13] - 2026-03-27
+
+### Fixed (Batch 45 — Complete ffmpeg/ffprobe Path Resolution)
+- **23 bare `"ffmpeg"` in subprocess calls** — 13 in route files (`audio.py`, `system.py`, `timeline.py`, `video_core.py` x7, `video_editing.py` x3) and 10 in core modules (`audio.py` x2, `audio_suite.py` x2, `highlights.py`, `loudness_match.py` x4, `scene_detect.py`). All replaced with `get_ffmpeg_path()`. On bundled installs where FFmpeg is not in system PATH, every one of these would crash with "command not found".
+
 ## [1.9.12] - 2026-03-27
 
 ### Fixed (Batch 44 — Dependencies & Hardcoded Ports)
diff --git a/CLAUDE.md b/CLAUDE.md
@@ -180,7 +180,7 @@
 - Lint: `ruff check opencut/` — codebase is fully clean, pre-commit enforces on every commit
 
 ## Version
-- Current: **v1.9.12**
+- Current: **v1.9.13**
 - All version strings: `pyproject.toml`, `__init__.py`, `CSXS/manifest.xml` (ExtensionBundleVersion + Version), `com.opencut.uxp/manifest.json`, `com.opencut.uxp/main.js` (VERSION const), `index.html` version display, README badge, `package.json`
 - Use `python scripts/sync_version.py --set X.Y.Z` to update all 19 targets at once (including UXP files and package.json)
 - Use `python scripts/sync_version.py --check` in CI to verify all targets match
@@ -919,6 +919,10 @@ enhance = ["resemble-enhance>=0.0.1"]
 - **10 duplicate class attributes in HTML** — 10 elements had two `class=` attributes; HTML parser silently ignores the second, losing spacing utilities (mt-xs, mt-sm, mb-sm, mt-md). All merged into single attributes.
 - **pip install permission denied** — `safe_pip_install()` failed on Windows when both normal and `--user` installs hit Errno 13 (Microsoft Store Python, OneDrive-synced user dirs, restrictive ACLs). Added `--target ~/.opencut/packages` as third fallback strategy. server.py adds `~/.opencut/packages` to `sys.path` at startup.
 
+## v1.9.13 Batch 45 (Complete ffmpeg Path Resolution)
+- **23 bare `"ffmpeg"` in subprocess calls** — 13 in routes + 10 in core modules. ALL replaced with `get_ffmpeg_path()`. Bundled installs now work for every FFmpeg operation.
+- Combined with batch 37's 14 ffprobe fixes: **every** subprocess call across the entire codebase now resolves FFmpeg/ffprobe via the cached path helper.
+
 ## v1.9.12 Batch 44 (Dependencies & Ports)
 - **psutil** added to core deps (was optional but used by /system/status).
 - **numpy** upper bound `<2` removed (dist already ships 2.x).
diff --git a/Install.ps1 b/Install.ps1
@@ -155,7 +155,7 @@ Write-Host "  \___/| .__/ \___|_| |_|\____\__,_|\__|" -ForegroundColor Cyan
 Write-Host "       |_|                               " -ForegroundColor Cyan
 Write-Host ""
 Write-Host "  Open Source Video Editing Automation" -ForegroundColor DarkGray
-Write-Host "  Installer v1.9.12" -ForegroundColor DarkGray
+Write-Host "  Installer v1.9.13" -ForegroundColor DarkGray
 
 $isAdmin = Test-IsAdmin
 if ($isAdmin) {
diff --git a/OpenCut.iss b/OpenCut.iss
@@ -2,7 +2,7 @@
 ; Fully self-contained installer — bundles server exe, ffmpeg, and CEP extension
 
 #define MyAppName "OpenCut"
-#define MyAppVersion "1.9.12"
+#define MyAppVersion "1.9.13"
 #define MyAppPublisher "SysAdminDoc"
 #define MyAppURL "https://github.com/SysAdminDoc/OpenCut"
 
diff --git a/extension/com.opencut.panel/CSXS/manifest.xml b/extension/com.opencut.panel/CSXS/manifest.xml
@@ -2,11 +2,11 @@
 <ExtensionManifest xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
                    Version="7.0"
                    ExtensionBundleId="com.opencut.panel"
-                   ExtensionBundleVersion="1.9.12"
+                   ExtensionBundleVersion="1.9.13"
                    ExtensionBundleName="OpenCut">
 
     <ExtensionList>
-        <Extension Id="com.opencut.panel.main" Version="1.9.12" />
+        <Extension Id="com.opencut.panel.main" Version="1.9.13" />
     </ExtensionList>
 
     <ExecutionEnvironment>
diff --git a/extension/com.opencut.panel/client/index.html b/extension/com.opencut.panel/client/index.html
@@ -3262,7 +3262,7 @@ <h1 class="content-title" id="contentTitle">Cut & Clean</h1>
                     <div class="card-header"><div class="card-title" data-i18n="settings.about">About OpenCut</div></div>
                     <div class="settings-row">
                         <span class="settings-label">Version</span>
-                        <span class="settings-value">1.9.12</span>
+                        <span class="settings-value">1.9.13</span>
                     </div>
                     <div class="about-links">
                         <a href="https://github.com/SysAdminDoc/opencut" class="about-link" target="_blank">GitHub</a>
diff --git a/extension/com.opencut.panel/client/main.js b/extension/com.opencut.panel/client/main.js
@@ -1,5 +1,5 @@
 /* ============================================================
-   OpenCut CEP Panel - Main Controller v1.9.12
+   OpenCut CEP Panel - Main Controller v1.9.13
    6-Tab Professional Toolkit
    ============================================================ */
 (function () {
diff --git a/extension/com.opencut.panel/client/style.css b/extension/com.opencut.panel/client/style.css
@@ -1,5 +1,5 @@
 /* ============================================================
-   OpenCut CEP Panel v1.9.12 - ULTRA PREMIUM EDITION
+   OpenCut CEP Panel v1.9.13 - ULTRA PREMIUM EDITION
    Next-Generation AI Editing Suite for Adobe Premiere Pro
    ============================================================ */
 
diff --git a/extension/com.opencut.panel/package.json b/extension/com.opencut.panel/package.json
@@ -1,6 +1,6 @@
 {
   "name": "opencut-panel",
-  "version": "1.9.12",
+  "version": "1.9.13",
   "private": true,
   "description": "OpenCut CEP Panel for Adobe Premiere Pro",
   "scripts": {
diff --git a/extension/com.opencut.uxp/index.html b/extension/com.opencut.uxp/index.html
@@ -16,7 +16,7 @@
           <path d="M4 2.5a3 3 0 00-1.76 5.43L7.33 11l-5.09 3.07A3 3 0 104.8 19.5a3 3 0 001.76-5.43L8.93 12.6 16.5 17V5L8.93 9.4 6.56 7.93A3 3 0 004 2.5z" fill="var(--accent)"/>
         </svg>
         <span class="oc-logo">OpenCut</span>
-        <span class="oc-version">v1.9.12</span>
+        <span class="oc-version">v1.9.13</span>
       </div>
       <div class="oc-header-right">
         <div class="oc-connection" id="connectionStatus" title="Backend connection status">
diff --git a/extension/com.opencut.uxp/main.js b/extension/com.opencut.uxp/main.js
@@ -26,7 +26,7 @@ const HEALTH_CHECK_MS  = 8000;
 const HEALTH_MAX_MS    = 60000;
 const MEDIA_SCAN_MS    = 30000;
 const SSE_AVAILABLE    = typeof EventSource !== "undefined";
-const VERSION          = "1.9.12";
+const VERSION          = "1.9.13";
 
 async function detectBackend() {
   // Try ports 5679-5689 like CEP panel does
diff --git a/extension/com.opencut.uxp/manifest.json b/extension/com.opencut.uxp/manifest.json
@@ -1,7 +1,7 @@
 {
   "id": "com.opencut.uxp",
   "name": "OpenCut UXP",
-  "version": "1.9.12",
+  "version": "1.9.13",
   "main": "index.html",
   "host": [
     {
diff --git a/install.py b/install.py
@@ -10,7 +10,7 @@
 import subprocess
 import platform
 
-VERS = "1.9.12"
+VERS = "1.9.13"
 CEP_EXT = "com.opencut.panel"
 WIN_CEP_DIR = os.path.expandvars(r"%APPDATA%\Adobe\CEP\extensions")
 MAC_CEP_DIR = os.path.expanduser("~/Library/Application Support/Adobe/CEP/extensions")
diff --git a/installer/src/OpenCut.Installer/Models/AppConstants.cs b/installer/src/OpenCut.Installer/Models/AppConstants.cs
@@ -3,7 +3,7 @@ namespace OpenCut.Installer.Models;
 public static class AppConstants
 {
     public const string AppName = "OpenCut";
-    public const string AppVersion = "1.9.12";
+    public const string AppVersion = "1.9.13";
     public const string AppDisplayName = $"{AppName} v{AppVersion}";
     public const string AppPublisher = "SysAdminDoc";
     public const string AppUrl = "https://github.com/SysAdminDoc/OpenCut";
diff --git a/installer/src/OpenCut.Installer/OpenCut.Installer.csproj b/installer/src/OpenCut.Installer/OpenCut.Installer.csproj
@@ -7,8 +7,8 @@
     <RootNamespace>OpenCut.Installer</RootNamespace>
     <AssemblyName>OpenCut-Setup</AssemblyName>
     <ApplicationIcon>Assets\logo.ico</ApplicationIcon>
-    <Version>1.9.12</Version>
-    <FileVersion>1.9.12.0</FileVersion>
+    <Version>1.9.13</Version>
+    <FileVersion>1.9.13.0</FileVersion>
     <AssemblyVersion>1.3.0.0</AssemblyVersion>
     <Company>SysAdminDoc</Company>
     <Product>OpenCut Installer</Product>
diff --git a/installer/src/OpenCut.Installer/Properties/app.manifest b/installer/src/OpenCut.Installer/Properties/app.manifest
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <assembly manifestVersion="1.0" xmlns="urn:schemas-microsoft-com:asm.v1">
-  <assemblyIdentity version="1.9.12.0" name="OpenCut.Installer" />
+  <assemblyIdentity version="1.9.13.0" name="OpenCut.Installer" />
   <trustInfo xmlns="urn:schemas-microsoft-com:asm.v2">
     <security>
       <requestedPrivileges xmlns="urn:schemas-microsoft-com:asm.v3">
diff --git a/opencut/__init__.py b/opencut/__init__.py
@@ -5,6 +5,6 @@
 and more. Exports Premiere Pro / DaVinci Resolve / FCP XML.
 """
 
-__version__ = "1.9.12"
+__version__ = "1.9.13"
 __author__ = "OpenCut Contributors"
 __license__ = "MIT"
diff --git a/opencut/core/audio.py b/opencut/core/audio.py
@@ -11,6 +11,8 @@
 from dataclasses import dataclass
 from typing import List, Optional, Tuple
 
+from opencut.helpers import get_ffmpeg_path
+
 from .silence import TimeSegment
 
 
@@ -41,7 +43,7 @@ def extract_audio_pcm(
     channels = "1" if mono else "2"
 
     cmd = [
-        "ffmpeg",
+        get_ffmpeg_path(),
         "-hide_banner",
         "-loglevel", "error",
         "-i", filepath,
@@ -77,7 +79,7 @@ def extract_audio_wav(filepath: str, output_path: Optional[str] = None, sample_r
         os.close(fd)
 
     cmd = [
-        "ffmpeg",
+        get_ffmpeg_path(),
         "-hide_banner",
         "-loglevel", "error",
         "-y",
diff --git a/opencut/core/audio_suite.py b/opencut/core/audio_suite.py
@@ -21,6 +21,8 @@
 from dataclasses import dataclass, field
 from typing import Callable, Dict, List, Optional, Tuple
 
+from opencut.helpers import get_ffmpeg_path
+
 logger = logging.getLogger("opencut")
 
 
@@ -214,7 +216,7 @@ def measure_loudness(input_path: str) -> LoudnessInfo:
         LoudnessInfo with integrated loudness, true peak, and range.
     """
     cmd = [
-        "ffmpeg", "-hide_banner", "-loglevel", "info",
+        get_ffmpeg_path(), "-hide_banner", "-loglevel", "info",
         "-i", input_path,
         "-af", "loudnorm=print_format=json",
         "-f", "null", "-",
@@ -309,7 +311,7 @@ def normalize_loudness(
         )
 
     cmd = [
-        "ffmpeg", "-hide_banner", "-loglevel", "info",
+        get_ffmpeg_path(), "-hide_banner", "-loglevel", "info",
         "-y", "-i", input_path,
         "-af", af_filter,
         "-c:v", "copy",
diff --git a/opencut/core/highlights.py b/opencut/core/highlights.py
@@ -511,7 +511,7 @@ def extract_frames_for_vision(
     import subprocess
     import tempfile
 
-    from opencut.helpers import get_ffprobe_path
+    from opencut.helpers import get_ffmpeg_path, get_ffprobe_path
     duration_cmd = subprocess.run(
         [get_ffprobe_path(), "-v", "quiet", "-show_entries", "format=duration",
          "-of", "default=nw=1:nk=1", video_path],
@@ -532,7 +532,7 @@ def extract_frames_for_vision(
         for i, ts in enumerate(timestamps):
             out_path = os.path.join(tmp_dir, f"frame_{i:04d}.jpg")
             subprocess.run(
-                ["ffmpeg", "-ss", str(ts), "-i", video_path,
+                [get_ffmpeg_path(), "-ss", str(ts), "-i", video_path,
                  "-vframes", "1", "-q:v", "5", "-vf", "scale=480:-1",
                  "-y", out_path],
                 capture_output=True, timeout=10,
diff --git a/opencut/core/loudness_match.py b/opencut/core/loudness_match.py
@@ -13,12 +13,18 @@
 from typing import List
 
 try:
+    from ..helpers import get_ffmpeg_path
     from ..helpers import run_ffmpeg as _helpers_run_ffmpeg
 except ImportError:
     try:
+        from opencut.helpers import get_ffmpeg_path
         from opencut.helpers import run_ffmpeg as _helpers_run_ffmpeg
     except ImportError:
         _helpers_run_ffmpeg = None  # type: ignore
+        from shutil import which as _which
+
+        def get_ffmpeg_path() -> str:  # type: ignore[misc]
+            return _which("ffmpeg") or "ffmpeg"
 
 logger = logging.getLogger("opencut")
 
@@ -59,7 +65,7 @@ def measure_loudness(filepath: str) -> dict:
         ValueError: If loudnorm output cannot be parsed.
     """
     cmd = [
-        "ffmpeg", "-hide_banner",
+        get_ffmpeg_path(), "-hide_banner",
         "-i", filepath,
         "-af", "loudnorm=print_format=json",
         "-vn",
@@ -134,7 +140,7 @@ def normalize_to_lufs(
     # --- Pass 1: Measure ---
     logger.debug("Loudness normalisation pass 1 (measure): %s", input_path)
     pass1_cmd = [
-        "ffmpeg", "-hide_banner",
+        get_ffmpeg_path(), "-hide_banner",
         "-i", input_path,
         "-af", f"loudnorm=I={target_lufs}:TP={true_peak}:LRA=11:print_format=json",
         "-vn",
@@ -191,7 +197,7 @@ def _mv(key: str, default: str = "0.0") -> str:
 
     if is_video:
         pass2_cmd = [
-            "ffmpeg", "-hide_banner", "-y",
+            get_ffmpeg_path(), "-hide_banner", "-y",
             "-i", input_path,
             "-af", loudnorm_filter,
             "-c:v", "copy",
@@ -200,7 +206,7 @@ def _mv(key: str, default: str = "0.0") -> str:
         ]
     else:
         pass2_cmd = [
-            "ffmpeg", "-hide_banner", "-y",
+            get_ffmpeg_path(), "-hide_banner", "-y",
             "-i", input_path,
             "-af", loudnorm_filter,
             "-c:a", "aac", "-b:a", "192k",
diff --git a/opencut/core/scene_detect.py b/opencut/core/scene_detect.py
@@ -14,7 +14,7 @@
 from dataclasses import dataclass, field
 from typing import Callable, Dict, List, Optional
 
-from opencut.helpers import get_ffprobe_path
+from opencut.helpers import get_ffmpeg_path, get_ffprobe_path
 
 logger = logging.getLogger("opencut")
 
@@ -84,7 +84,7 @@ def detect_scenes(
     # Use FFmpeg select filter to detect scene changes
     # This outputs timestamps where scene changes occur
     cmd = [
-        "ffmpeg", "-hide_banner", "-loglevel", "info",
+        get_ffmpeg_path(), "-hide_banner", "-loglevel", "info",
         "-i", input_path,
         "-vf", f"select='gt(scene,{max(0.0, min(1.0, float(threshold)))})',showinfo",
         "-f", "null", "-",
diff --git a/opencut/routes/audio.py b/opencut/routes/audio.py
@@ -20,6 +20,7 @@
 from opencut.helpers import (
     _make_sequence_name,
     _resolve_output_dir,
+    get_ffmpeg_path,
     get_ffprobe_path,
 )
 from opencut.jobs import (
@@ -1360,7 +1361,7 @@ def audio_waveform(job_id, filepath, data):
 
     # Extract raw audio samples as 16-bit PCM
     cmd = [
-        "ffmpeg", "-i", file_path, "-ac", "1", "-ar", "8000",
+        get_ffmpeg_path(), "-i", file_path, "-ac", "1", "-ar", "8000",
         "-f", "s16le", "-acodec", "pcm_s16le", "-v", "error", "-"
     ]
     result = _sp.run(cmd, capture_output=True, timeout=120)
diff --git a/opencut/routes/system.py b/opencut/routes/system.py
@@ -24,7 +24,7 @@
 
 from opencut import __version__
 from opencut.errors import safe_error
-from opencut.helpers import OPENCUT_DIR, _try_import, _try_import_from
+from opencut.helpers import OPENCUT_DIR, _try_import, _try_import_from, get_ffmpeg_path
 from opencut.jobs import (
     _is_cancelled,
     _list_jobs_copy,
@@ -569,7 +569,7 @@ def check_dependencies():
 
     # Check FFmpeg
     try:
-        r = _sp.run(["ffmpeg", "-version"], capture_output=True, text=True, timeout=5)
+        r = _sp.run([get_ffmpeg_path(), "-version"], capture_output=True, text=True, timeout=5)
         line = r.stdout.split("\n")[0] if r.stdout else ""
         deps["ffmpeg"] = {"installed": True, "version": line}
     except Exception:
diff --git a/opencut/routes/timeline.py b/opencut/routes/timeline.py
@@ -11,6 +11,7 @@
 from flask import Blueprint, jsonify, request
 
 from opencut.errors import safe_error
+from opencut.helpers import get_ffmpeg_path
 from opencut.jobs import (
     _is_cancelled,
     _update_job,
@@ -91,7 +92,7 @@ def timeline_export_from_markers(job_id, filepath, data):
         _update_job(job_id, progress=pct, message=f"Extracting marker '{name}' ({idx + 1}/{total})...")
 
         cmd = [
-            "ffmpeg", "-y",
+            get_ffmpeg_path(), "-y",
             "-i", input_file,
             "-ss", str(start),
             "-t", str(duration),
diff --git a/opencut/routes/video_core.py b/opencut/routes/video_core.py
diff --git a/opencut/routes/video_editing.py b/opencut/routes/video_editing.py
diff --git a/pyproject.toml b/pyproject.toml
diff --git a/requirements.txt b/requirements.txt

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "opencut-panel",`
`3`		`- "version": "1.9.12",`
	`3`	`+ "version": "1.9.13",`
`4`	`4`	`"private": true,`
`5`	`5`	`"description": "OpenCut CEP Panel for Adobe Premiere Pro",`
`6`	`6`	`"scripts": {`