Skip to content

fix(select): clear placeholder on value select #432#433

Merged
mart-sessman merged 1 commit into
mainfrom
fix/432-searchable-select-placeholder-fix
May 4, 2026
Merged

fix(select): clear placeholder on value select #432#433
mart-sessman merged 1 commit into
mainfrom
fix/432-searchable-select-placeholder-fix

Conversation

@mart-sessman
Copy link
Copy Markdown
Contributor

@mart-sessman mart-sessman commented May 4, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Improved searchable select components by hiding the input placeholder text when an option is selected, then restoring it when searching for a different item. This provides clearer visual feedback during selection workflows.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f1dc5a53-1a09-4a66-8b88-75f2b6151684

📥 Commits

Reviewing files that changed from the base of the PR and between 9e8e51f and e809fa0.

📒 Files selected for processing (2)
  • tedi/components/form/select/select.component.html
  • tedi/components/form/select/select.component.spec.ts

📝 Walkthrough

Walkthrough

The searchable select component's search input placeholder is now conditionally set to an empty string when a single value is shown; otherwise it displays the configured placeholder. A test verifies this behavior after option selection.

Changes

Placeholder Binding & Test

Layer / File(s) Summary
Template Logic
tedi/components/form/select/select.component.html
Search input placeholder binding becomes conditional: empty string when showSingleSelectedValue() is true, otherwise uses configured placeholder().
Tests
tedi/components/form/select/select.component.spec.ts
New test verifies that the search input's placeholder attribute is empty after an option is selected in a searchable select.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

  • airikej
  • ly-tempel-bitweb
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/432-searchable-select-placeholder-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@mart-sessman mart-sessman merged commit f87ef36 into main May 4, 2026
19 of 22 checks passed
@mart-sessman mart-sessman deleted the fix/432-searchable-select-placeholder-fix branch May 4, 2026 06:52
github-actions Bot pushed a commit that referenced this pull request May 4, 2026
## [6.3.1](angular-6.3.0...angular-6.3.1) (2026-05-04)

### Bug Fixes

* **select:** clear placeholder on value select [#432](#432) ([#433](#433)) ([f87ef36](f87ef36))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants