fix(collapse): add button type to prevent form submission #434

[ly-tempel-bitweb]

Summary by CodeRabbit

• Bug Fixes

  • Collapse button now explicitly sets the type attribute.

• Tests

  • Added test assertion to verify the button type attribute is properly set.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1d9ffa86-0564-4216-ba28-0aec44f5cd22

📥 Commits

Reviewing files that changed from the base of the PR and between a575670 and be984dc.

📒 Files selected for processing (2)

• tedi/components/buttons/collapse/collapse.component.html
• tedi/components/buttons/collapse/collapse.component.spec.ts

---

📝 Walkthrough

Walkthrough

The collapse component button element is updated to explicitly set type="button" to prevent form submission when clicked. A corresponding test assertion verifies the button renders with the correct type attribute.

Changes

Collapse button type attribute

Layer / File(s)	Summary
Button type declaration and test tedi/components/buttons/collapse/collapse.component.html, tedi/components/buttons/collapse/collapse.component.spec.ts	The toggle button element declares type="button" to prevent submitting parent forms, and a new test case verifies the type attribute is set correctly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title clearly summarizes the main change: adding a button type attribute to the collapse component to prevent form submission. The title is specific, concise, and directly related to the changeset modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/434-add-button-type-for-collapse

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[ly-tempel-bitweb]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.