Skip to content

Ignore default track labels#108

Open
MattiasBuelens wants to merge 6 commits intomainfrom
bugfix/ignore-default-track-label
Open

Ignore default track labels#108
MattiasBuelens wants to merge 6 commits intomainfrom
bugfix/ignore-default-track-label

Conversation

@MattiasBuelens
Copy link
Copy Markdown
Contributor

THEOplayer sometimes sets TextTrack.label or MediaTrack.label to a default value, which can be:

  • The localized language name, e.g. "English"
  • The language code, e.g. "en"
  • For CEA-608 closed captions: the caption channel number, e.g. "CC1"

This PR detects these "default labels" so we can replace them with our own logic. This will also allow THEOplayer to (eventually) stop localizing language names in the SDK itself, and instead delegate that to the UI logic.

This aligns with THEOplayer/android-ui#84, THEOplayer/android-ui#95 and THEOplayer/web-ui#135.

@MattiasBuelens MattiasBuelens added the enhancement New feature or request label Apr 7, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 7, 2026

🦋 Changeset detected

Latest commit: a46fc6a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@theoplayer/react-native-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread src/ui/components/util/TrackUtils.ts Outdated
@MattiasBuelens MattiasBuelens force-pushed the bugfix/ignore-default-track-label branch from 42be443 to ffe15a7 Compare April 14, 2026 12:48
@MattiasBuelens MattiasBuelens marked this pull request as draft April 14, 2026 13:21
@MattiasBuelens MattiasBuelens force-pushed the bugfix/ignore-default-track-label branch from 8e649e4 to 3825887 Compare April 16, 2026 14:55
@MattiasBuelens MattiasBuelens force-pushed the bugfix/ignore-default-track-label branch from 3825887 to a46fc6a Compare April 16, 2026 17:16
@MattiasBuelens MattiasBuelens marked this pull request as ready for review April 16, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants