Open
Conversation
🦋 Changeset detectedLatest commit: a46fc6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tvanlaerhoven
approved these changes
Apr 13, 2026
MattiasBuelens
commented
Apr 14, 2026
42be443 to
ffe15a7
Compare
8e649e4 to
3825887
Compare
3825887 to
a46fc6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THEOplayer sometimes sets
TextTrack.labelorMediaTrack.labelto a default value, which can be:"English""en""CC1"This PR detects these "default labels" so we can replace them with our own logic. This will also allow THEOplayer to (eventually) stop localizing language names in the SDK itself, and instead delegate that to the UI logic.
This aligns with THEOplayer/android-ui#84, THEOplayer/android-ui#95 and THEOplayer/web-ui#135.