Solve synchronization of KI's between KB and KER#13
Open
DaviddeBest-TNO wants to merge 4 commits intomainfrom
Open
Solve synchronization of KI's between KB and KER#13DaviddeBest-TNO wants to merge 4 commits intomainfrom
DaviddeBest-TNO wants to merge 4 commits intomainfrom
Conversation
3 tasks
Sophietje
reviewed
Apr 3, 2026
| """ | ||
| ... | ||
|
|
||
| def get_knowledge_interactions(self, kb_id: str) -> list[KnowledgeInteractionInfo]: |
There was a problem hiding this comment.
Misschien get_all_knowledge_interactions noemen zodat de naming consistent is met de get_all_knowledge_bases
| self.registered = True | ||
| self.register_deferred_kis() | ||
| self.client.register_kb(self.info, reregister=True) | ||
| self.state = KnowledgeBaseState.REGISTERED |
There was a problem hiding this comment.
Wat gebeurt er als register_kb niet succeed/faalt met een exceptie? Wordt de state dan alsnog op REGISTERED gezet?
| self.deferred_kis.clear() | ||
| def sync_knowledge_interactions(self) -> None: | ||
| """Synchronize registration of knowledge interactions in this object's registry | ||
| with the interactions registered at the KE runtime, so all unregistered KIs in |
There was a problem hiding this comment.
it's not the KIs in the registry that are unregistered right, but the KIs that are unregistered will be added to the registry?
Perhaps slight rewording helps to clarify this: "so all unregistered KIs are registered in the registry"
| the KE runtime. | ||
| UnexpectedHttpResponseError: If the KE runtime returns an unexpected HTTP | ||
| response. | ||
| Exception: If an unexpected poll result is returned. |
There was a problem hiding this comment.
Could this Exception be made more specific?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #12
Tests for various (incorrect) scenarios, like KI registration before KB registration, double registration, duplicate names, etc.