[TASK] Split PHPStan CI jobs by Starkmann · Pull Request #2050 · TYPO3BestPractices/tea

Starkmann · 2026-03-28T11:40:49Z

Resolves: #1827

…mposer command to native phpstan command Related: #1827

Related: #1827

coveralls · 2026-03-28T11:42:58Z

Coverage Report for CI Build 26807031978

Coverage remained the same at 92.089%

Details

Coverage remained the same as the base build.
Patch coverage: No coverable lines changed in this PR.
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	316
Covered Lines:	291
Line Coverage:	92.09%
Coverage Strength:	3.79 hits per line

💛 - Coveralls

Related: #1827

This reverts commit f469843.

…ne for TYPO3 13 only Related: #1827

Related: #1827

…pstan-jobs

Related: #1827

oliverklee

When I run this for TYPO3 13LTS, checking the code with PHPStan works fine.

When I run it with TYPO3 12LTS, I get errors, though:


klee@gonzales ~/src/typo3/ext/tea (feature/1827-split-phpstan-jobs)$ ./Build/Scripts/runTests.sh -t 12.4 -s phpstan
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   Classes/Domain/Repository/TeaRepository.php                                                                                                                                       
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  24     Method TTN\Tea\Domain\Repository\TeaRepository::findByOwnerUid() return type with generic interface TYPO3\CMS\Extbase\Persistence\QueryResultInterface does not specify its       
         types: TKey, TValue                                                                                                                                                               
         🪪  missingType.generics                                                                                                                                                          
  36     Method TTN\Tea\Domain\Repository\TeaRepository::findAllFromAllPages() return type with generic interface TYPO3\CMS\Extbase\Persistence\QueryResultInterface does not specify its  
         types: TKey, TValue                                                                                                                                                               
         🪪  missingType.generics                                                                                                                                                          
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------ 
  Line   Tests/Functional/Controller/BackendModuleControllerTest.php                                                                   
 ------ ------------------------------------------------------------------------------------------------------------------------------ 
         Ignored error pattern #^Call to method hmac\(\) on an unknown class TYPO3\\CMS\\Core\\Crypto\\HashService\.$# in path         
         /home/klee/src/typo3/ext/tea/Tests/Functional/Controller/BackendModuleControllerTest.php was not matched in reported errors.  
         🪪  ignore.unmatched (non-ignorable)                                                                                          
         Ignored error pattern #^Class TYPO3\\CMS\\Core\\Crypto\\HashService not found\.$# in path                                     
         /home/klee/src/typo3/ext/tea/Tests/Functional/Controller/BackendModuleControllerTest.php was not matched in reported errors.  
         🪪  ignore.unmatched (non-ignorable)                                                                                          
 ------ ------------------------------------------------------------------------------------------------------------------------------ 

                                                                                                                        
 [ERROR] Found 4 errors

oliverklee · 2026-06-04T14:52:18Z

+      - name: Cache dependencies installed with composer
+        uses: actions/cache@v5
+        with:
+          key: "php-${{ matrix.php-version }}-typo3-${{ matrix.typo3-version }}-${{ matrix.composer-dependencies }}-composer-${{ hashFiles('**/composer.json') }}"


We also need to have the Max dependencies in the CI matrix so the cache keys are correct.

oliverklee · 2026-06-04T14:53:09Z

+          restore-keys: "php-${{ matrix.php-version }}-typo3-${{ matrix.typo3-version }}-${{ matrix.composer-dependencies }}-composer-\n"
+      - name: Install composer dependencies
+        run: |
+          ./Build/Scripts/runTests.sh -p ${{ matrix.php-version }} -t ${{matrix.typo3-version}} -s composerUpdateMax


… and use ${{ matrix.composer-dependencies }} here. (We should copy this from the other jobs so they are identical and easier to maintain.)

oliverklee · 2026-06-04T14:54:40Z

+    COMMAND=(php -dxdebug.mode=off .Build/bin/phpstan analyse -c ${PHPSTAN_CONFIG_FILE} --no-progress --no-interaction --memory-limit 4G "$@")
+    ${CONTAINER_BIN} run ${CONTAINER_COMMON_PARAMS} --name phpstan-${SUFFIX} -e COMPOSER_CACHE_DIR=.cache/composer -e COMPOSER_ROOT_VERSION=${COMPOSER_ROOT_VERSION} ${IMAGE_PHP} "${COMMAND[@]}"
+}
+phpstanGenerateBaseline() {


There should be a blank line above this line so the scripts are separated.

oliverklee · 2026-06-04T14:56:27Z

        ;;
    phpstan)
-        phpstan
+        phpstan "$@"


Why do we need to pass the parameters here and in the other function?

oliverklee · 2026-06-04T14:56:48Z

 		"check:php:cs-fixer": "php-cs-fixer fix --config ./Build/php-cs-fixer/config.php -v --dry-run --diff",
 		"check:php:lint": "parallel-lint *.php Build Classes Configuration Tests",
 		"check:php:rector": "rector process --dry-run --config=./Build/rector/config.php",
-		"check:php:stan": "phpstan --no-progress -v --configuration=Build/phpstan/phpstan.neon",


We also need to update the documentation that mentions this script.

oliverklee · 2026-06-04T15:30:23Z

When I run it with TYPO3 12LTS, I get errors, though:

Scratch that - I had forgotten to install the 12LTS packages.

[TASK] create two versions of phpstan configuration and switch fom co…

8c95542

…mposer command to native phpstan command Related: #1827

Starkmann added this to the 4.0.0: Drop support for TYPO3 11LTS and PHP 7.4/8.0, add support for 13LTS milestone Mar 28, 2026

Starkmann self-assigned this Mar 28, 2026

Starkmann added this to Best Practices code sprint Mar 28, 2026

Starkmann added compatibility with current main feature labels Mar 28, 2026

[TASK] add matrix test for both TYPO3 versions to ci

01e9270

Related: #1827

Starkmann force-pushed the feature/1827-split-phpstan-jobs branch from a0a3866 to 01e9270 Compare March 28, 2026 11:42

oliverklee moved this to In Progress in Best Practices code sprint Mar 28, 2026

oliverklee changed the title ~~Split phpstan jobs~~ [TASK] Split PHPStan CI jobs Mar 28, 2026

Starkmann added 5 commits March 28, 2026 12:55

[TASK] remove phpstan composer command

52c5c89

Related: #1827

[BUGFIX] use correct command

5eef64c

Related: #1827

[TASK] add php version to matrix

6e60668

Related: #1827

[BUGFIX] remove duplicate composerUpdateMax

8ac7235

Related: #1827

[TASK] remove no longer needed composer phpstan commands

0fa9260

Related: #1827

DanielSiepmann reviewed Mar 28, 2026

View reviewed changes

Comment thread Build/phpstan/TYPO3_13.4/phpstan.neon Outdated

Comment thread Build/phpstan/TYPO3_13.4/phpstan.neon

[TASK] create a base phpstan config to remove dublicate code

bc6a4f8

Related: #1827

oliverklee modified the milestones: 4.0.0: Drop support for TYPO3 11LTS and PHP 7.4/8.0, add support for 13LTS, 4.1.0 Apr 2, 2026

Starkmann added 8 commits June 1, 2026 12:45

Merge branch 'main' into feature/1827-split-phpstan-jobs

64805d7

[TASK] clean up and refactor ignore errors

f469843

Related: #1827

Revert "[TASK] clean up and refactor ignore errors"

5468f81

This reverts commit f469843.

[TASK] remove no longer needed errors and activate rawMessageInBaseli…

3895932

…ne for TYPO3 13 only Related: #1827

[BUGFIX] HashService does not exist for TYPO3 12

ed74100

Related: #1827

Merge remote-tracking branch 'origin/main' into feature/1827-split-ph…

6ee4e68

…pstan-jobs

[BUGFIX] remove no longer needed function

30ea535

Related: #1827

[BUGFIX] remove no longer needed function

d3878de

Related: #1827

oliverklee moved this from In Progress to In Review in Best Practices code sprint Jun 1, 2026

oliverklee requested a review from a team June 1, 2026 14:28

oliverklee requested changes Jun 1, 2026

View reviewed changes

Comment thread .github/workflows/ci.yml Outdated

Comment thread .github/workflows/ci.yml Outdated

Comment thread .github/workflows/ci.yml

Comment thread Build/Scripts/runTests.sh

github-project-automation Bot moved this from In Review to In Progress in Best Practices code sprint Jun 1, 2026

Starkmann added 2 commits June 1, 2026 16:44

[BUGFIX] remove not needed matrix and add composer cache

aa85e1d

Related: #1827

[TASK] remove phpstan functionality to functions

a3b2d5a

Related: #1827

Starkmann requested a review from oliverklee June 1, 2026 17:20

Merge branch 'main' into feature/1827-split-phpstan-jobs

d1404a0

oliverklee moved this from In Progress to In Review in Best Practices code sprint Jun 4, 2026

oliverklee requested changes Jun 4, 2026

View reviewed changes

github-project-automation Bot moved this from In Review to In Progress in Best Practices code sprint Jun 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TASK] Split PHPStan CI jobs#2050

[TASK] Split PHPStan CI jobs#2050
Starkmann wants to merge 19 commits into
mainfrom
feature/1827-split-phpstan-jobs

Starkmann commented Mar 28, 2026

Uh oh!

coveralls commented Mar 28, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oliverklee left a comment

Uh oh!

oliverklee Jun 4, 2026

Uh oh!

oliverklee Jun 4, 2026

Uh oh!

oliverklee Jun 4, 2026

Uh oh!

oliverklee Jun 4, 2026

Uh oh!

oliverklee Jun 4, 2026

Uh oh!

oliverklee commented Jun 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Starkmann commented Mar 28, 2026

Uh oh!

coveralls commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 26807031978

Coverage remained the same at 92.089%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oliverklee left a comment

Choose a reason for hiding this comment

Uh oh!

oliverklee Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

oliverklee Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

oliverklee Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

oliverklee Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

oliverklee Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

oliverklee commented Jun 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Mar 28, 2026 •

edited

Loading