[TASK] Add tests for the model property validations#2127
Open
hermannatz wants to merge 2 commits into
Open
Conversation
oliverklee
force-pushed
the
feature/458-add-length-validation-model-fields
branch
from
ba35c8c to
f8bb3da
Compare
oliverklee
requested changes
May 19, 2026
Contributor
oliverklee
left a comment
oliverklee
left a comment
There was a problem hiding this comment.
Looks already quite good - thank your for this!
I've added some remarks.
Also, the PR title should read:
[TASK] Add tests for the model property validations
| $result = $validator->validate($this->subject); | ||
| self::assertTrue($result->forProperty('description')->hasErrors()); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Please remove this blank line.
This was referenced May 19, 2026
hermannatz
changed the title
hermannatz
force-pushed
the
feature/458-add-length-validation-model-fields
branch
from
d2ad8ed to
e11b850
Compare
added 2 commits
June 1, 2026 13:19
Add functional tests for title and description validation to verify the configured Extbase validators. Resolves: TYPO3BestPractices#458 Releases: main"
hermannatz
force-pushed
the
feature/458-add-length-validation-model-fields
branch
from
e11b850 to
f159a00
Compare
oliverklee
requested changes
Jun 1, 2026
| { | ||
| parent::setUp(); | ||
| $this->subject = new Tea(); | ||
| $validatorResolver = $this->getContainer()->get(ValidatorResolver::class); |
Contributor
There was a problem hiding this comment.
We'll most probably be able to skip getContainer() here:
Suggested change
| $validatorResolver = $this->getContainer()->get(ValidatorResolver::class); | |
| $validatorResolver = $this->get(ValidatorResolver::class); |
| protected function setUp(): void | ||
| { | ||
| parent::setUp(); | ||
| $this->subject = new Tea(); |
Contributor
There was a problem hiding this comment.
In general, creating the subject should be the last line in setUp() (if possible).
|
|
||
| protected function setUp(): void | ||
| { | ||
| parent::setUp(); |
Contributor
There was a problem hiding this comment.
Generally, we should have a blank line after parent::setUp();.
| protected array $testExtensionsToLoad = ['ttn/tea']; | ||
|
|
||
| private Tea $subject; | ||
| private ConjunctionValidator $validator; |
Contributor
There was a problem hiding this comment.
Please autoformat - there should be an empty line between the properties.
| { | ||
| $this->subject->setDescription(str_repeat('d', 2000)); | ||
| $result = $this->validator->validate($this->subject); | ||
| self::assertFalse($result->forProperty('description')->hasErrors()); |
Contributor
There was a problem hiding this comment.
In all tests, please add blank lines between the different test phases:
- test-specific setup (set the data)
- execution (
validatecall) - validation (
assert*call)
I've visualized this on a slide in one of my presentations on testing.
github-project-automation
Bot
moved this from In Review
to In Progress
in Best Practices code sprint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add functional tests for title and description validation to verify the configured Extbase validators.
Resolves: #458