Skip to content

[FEATURE] Use PHP script for XLIFF check in runTests.sh#2148

Merged
oliverklee merged 13 commits into
mainfrom
feature/1871-check-xliff-in-runtests
Jun 5, 2026
Merged

[FEATURE] Use PHP script for XLIFF check in runTests.sh#2148
oliverklee merged 13 commits into
mainfrom
feature/1871-check-xliff-in-runtests

Conversation

@kanow
Copy link
Copy Markdown
Contributor

@kanow kanow commented Jun 1, 2026

Same as the core does the xliff check.

@kanow kanow added this to the 4.1.0 milestone Jun 1, 2026
@kanow kanow self-assigned this Jun 1, 2026
@kanow kanow added the enhancement New feature or request label Jun 1, 2026
@kanow kanow marked this pull request as draft June 1, 2026 10:44
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 1, 2026

Coverage Report for CI Build 27007007138

Coverage remained the same at 92.089%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 316
Covered Lines: 291
Line Coverage: 92.09%
Coverage Strength: 3.79 hits per line

💛 - Coveralls

@kanow kanow force-pushed the feature/1871-check-xliff-in-runtests branch 2 times, most recently from db29d41 to b3217c1 Compare June 1, 2026 13:37
@kanow kanow force-pushed the feature/1871-check-xliff-in-runtests branch 2 times, most recently from 2fc2b52 to cdd9c9a Compare June 1, 2026 14:17
@kanow kanow marked this pull request as ready for review June 1, 2026 14:17
@kanow kanow marked this pull request as draft June 1, 2026 14:17
@kanow kanow marked this pull request as ready for review June 1, 2026 14:30
@kanow
Copy link
Copy Markdown
Contributor Author

kanow commented Jun 1, 2026

I checked the functionality of the old lintXliff check. IMO the new che does all the things that the old lint command did. Therefore I removed the old lintXliff command.
I'm not sure about the naming of the composer script. For the moment i didn't change the script naming for composer. The name in github workflow is therefore also not changed.

@kanow kanow force-pushed the feature/1871-check-xliff-in-runtests branch from cdd9c9a to b5c01fb Compare June 1, 2026 14:40
@oliverklee oliverklee changed the title [Feature] Use php script for xliff check in runtests [Feature] Use PHP script for XLIFF check in runTests.sh Jun 1, 2026
@oliverklee oliverklee changed the title [Feature] Use PHP script for XLIFF check in runTests.sh [FEATURE] Use PHP script for XLIFF check in runTests.sh Jun 1, 2026
@oliverklee oliverklee moved this from Todo to In Review in Best Practices code sprint Jun 1, 2026
@oliverklee oliverklee requested a review from a team June 1, 2026 14:45
Comment thread Build/Scripts/checkIntegrityXliff.php Outdated
Comment thread Build/Scripts/checkIntegrityXliff.php Outdated
Comment thread Build/Scripts/checkIntegrityXliff.php Outdated
Comment thread composer.json Outdated
Comment thread composer.json Outdated
@github-project-automation github-project-automation Bot moved this from In Review to In Progress in Best Practices code sprint Jun 4, 2026
@oliverklee oliverklee moved this from In Progress to In Review in Best Practices code sprint Jun 4, 2026
@oliverklee oliverklee moved this from In Review to In Progress in Best Practices code sprint Jun 4, 2026
@kanow kanow force-pushed the feature/1871-check-xliff-in-runtests branch 2 times, most recently from abb0b99 to b3fbd68 Compare June 4, 2026 15:28
@kanow

This comment was marked as resolved.

@oliverklee

This comment was marked as resolved.

@kanow kanow force-pushed the feature/1871-check-xliff-in-runtests branch from 11075e3 to 7c80962 Compare June 5, 2026 09:28
@kanow
Copy link
Copy Markdown
Contributor Author

kanow commented Jun 5, 2026

Too much clean up ;-)
@oliverklee done, checks green

@oliverklee oliverklee merged commit d406bf5 into main Jun 5, 2026
45 checks passed
@oliverklee oliverklee deleted the feature/1871-check-xliff-in-runtests branch June 5, 2026 10:58
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Best Practices code sprint Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

3 participants