Skip to content

[CLEANUP] Autoformat the XLIFF files#2166

Merged
kanow merged 1 commit into
mainfrom
cleanup/autoformat-xliff
Jun 2, 2026
Merged

[CLEANUP] Autoformat the XLIFF files#2166
kanow merged 1 commit into
mainfrom
cleanup/autoformat-xliff

Conversation

@oliverklee
Copy link
Copy Markdown
Contributor

No description provided.

@oliverklee oliverklee added this to the 4.1.0 milestone Jun 1, 2026
@oliverklee oliverklee requested a review from a team June 1, 2026 14:41
@oliverklee oliverklee self-assigned this Jun 1, 2026
@oliverklee oliverklee moved this from Todo to In Review in Best Practices code sprint Jun 1, 2026
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 26762007555

Coverage remained the same at 92.089%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 316
Covered Lines: 291
Line Coverage: 92.09%
Coverage Strength: 3.79 hits per line

💛 - Coveralls

@kanow
Copy link
Copy Markdown
Contributor

kanow commented Jun 1, 2026

@oliverklee It looks to me there are no rules for moving code in the next line. A little bit confusing. Sometimes the original is starting the new line, sometimes the date. Is that normal? Should that be in this way?

@oliverklee
Copy link
Copy Markdown
Contributor Author

It looks to me there are no rules for moving code in the next line. A little bit confusing. Sometimes the original is starting the new line, sometimes the date. Is that normal? Should that be in this way?

I think PhpStorm is doing this:

"Fit as many things as possible on the line, and then break before the allowed maximum length (as configured in PhpStorm) is reached."

@kanow
Copy link
Copy Markdown
Contributor

kanow commented Jun 2, 2026

If this depends on configuration of PhpStorm (or another IDE) then, maybe if another user is formatting the code, we have the next change? I'm not sure that we should change it here. What is the point of this change? Is this kind of "Best Practice"? Probably, yes. And if you like it, then I don't have a problem with that. Just want to thinking and talk about it.

@oliverklee
Copy link
Copy Markdown
Contributor Author

I'm not sure that we should change it here. What is the point of this change?

When I a developer edits a file, they should be able to autoformat it with the default PhpStorm settings to clean up their changes without introducing unrelated formatting changes.

@kanow
Copy link
Copy Markdown
Contributor

kanow commented Jun 2, 2026

Ok.

@kanow kanow merged commit ce892c8 into main Jun 2, 2026
45 checks passed
@kanow kanow deleted the cleanup/autoformat-xliff branch June 2, 2026 08:12
@github-project-automation github-project-automation Bot moved this from In Review to Done in Best Practices code sprint Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

3 participants