build(plugin-mssql): rebuild FreeTDS with Kerberos, fix GSS verification (#1918)#1923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1922. Actually ships the Kerberos-enabled FreeTDS library and re-releases the plugin against it.
Context
#1922 changed the build recipe but did not ship a fixed binary: the
libsybdb.aon thelibs-v1release still hadtds_gss_get_authabsent, so Windows Authentication kept failing. This PR rebuilds the library with Kerberos, publishes it, and fixes two build-script bugs found while rebuilding.What the rebuild found
--enable-krb5=gssapi_krb5does compile GSS in:ENABLE_KRB5is defined andgssapi.cbuildstds_gss_get_authagainst the SDK'slibgssapi_krb5.tbd. Verifiednm Libs/libsybdb.ashowsT _tds_gss_get_authon both arm64 and x86_64.grep -qcloses the pipe on the first match,nmthen dies with SIGPIPE, and underset -o pipefailthe pipeline reports failure for a valid library. Fixed by drainingnm's full output (grep ... > /dev/null, no-q).Changes
scripts/build-freetds.sh: fix the GSS verification (pipefail/SIGPIPE), and write the committed macOS archives before the iOS slices.Libs/checksums.sha256: updated for the four rebuiltlibsybdbarchives (published tolibs-v1viascripts/publish-libs.sh; all other libraries verified unchanged against HEAD).Verification
Release steps
tablepro-libs-v1.tar.gzonlibs-v1is already updated (only the fourlibsybdbarchives changed).main, tagplugin-mssql-v1.0.31so the registry plugin rebuilds against the Kerberos-enabled library. The plugin CI'sdownload-libs.shverifies the new archive against the checksums committed here, so this must merge first.currentPluginKitVersionstays 18.The iOS xcframework is unchanged. It stays krb5-free (the iOS app rejects Windows auth), and its build is not required for the macOS plugin.