feat(connections): create a connection from a project folder (#1959) #1960
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| // | ||
| // AppSettingsJsonExtractor.swift | ||
| // TablePro | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| enum AppSettingsJsonExtractor { | ||
| static func extract(data: Data, relativePath: String) -> [ScannedConnectionCandidate] { | ||
| guard let root = try? JSONSerialization.jsonObject(with: data) as? [String: Any] else { | ||
| return [] | ||
| } | ||
| guard let strings = connectionStrings(in: root) else { | ||
| return [] | ||
| } | ||
| return strings.sorted { $0.key < $1.key }.compactMap { name, value in | ||
| candidate(name: name, connectionString: value, relativePath: relativePath) | ||
| } | ||
| } | ||
|
|
||
| private static func connectionStrings(in root: [String: Any]) -> [String: String]? { | ||
| for (key, value) in root where key.lowercased() == "connectionstrings" { | ||
| guard let nested = value as? [String: Any] else { | ||
| continue | ||
| } | ||
| return nested.compactMapValues { $0 as? String } | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| static func candidate( | ||
| name: String, | ||
| connectionString: String, | ||
| relativePath: String | ||
| ) -> ScannedConnectionCandidate? { | ||
| let keywords = parseKeywords(connectionString) | ||
| guard let type = provider(for: keywords) else { | ||
| return nil | ||
| } | ||
| var fields = ScannedConnectionFields(type: type) | ||
| fields.host = first(keywords, ["host", "server", "data source", "address", "addr", "network address"]) ?? "" | ||
| fields.database = first(keywords, ["database", "initial catalog"]) ?? "" | ||
| fields.username = first(keywords, ["username", "user id", "uid", "user"]) ?? "" | ||
| fields.password = first(keywords, ["password", "pwd"]) ?? "" | ||
| fields.connectionName = name | ||
| let address = splitHostPort(fields.host, type: type) | ||
| fields.host = address.host | ||
| fields.port = first(keywords, ["port"]).flatMap { Int($0) } ?? address.port ?? type.defaultPort | ||
| return ScannedConnectionCandidate( | ||
| parsedURL: fields.toParsedConnectionURL(), | ||
| sourceRelativePath: relativePath, | ||
| sourceKey: "ConnectionStrings:\(name)", | ||
| kind: .appSettingsJson, | ||
| tier: .configFile | ||
| ) | ||
| } | ||
|
|
||
| static func parseKeywords(_ connectionString: String) -> [String: String] { | ||
| var keywords: [String: String] = [:] | ||
| for segment in connectionString.split(separator: ";") { | ||
| guard let equals = segment.firstIndex(of: "=") else { | ||
| continue | ||
| } | ||
| let key = String(segment[segment.startIndex..<equals]) | ||
| .trimmingCharacters(in: .whitespaces) | ||
| .lowercased() | ||
| let value = String(segment[segment.index(after: equals)...]).trimmingCharacters(in: .whitespaces) | ||
| guard !key.isEmpty, !value.isEmpty else { | ||
| continue | ||
| } | ||
| keywords[key] = value | ||
| } | ||
| return keywords | ||
| } | ||
|
|
||
| static func provider(for keywords: [String: String]) -> DatabaseType? { | ||
| if keywords["host"] != nil { | ||
| return .postgresql | ||
| } | ||
| if keywords["initial catalog"] != nil { | ||
| return .mssql | ||
| } | ||
| let sqlServerHints = ["trusted_connection", "encrypt", "trustservercertificate", "integrated security"] | ||
| if sqlServerHints.contains(where: { keywords[$0] != nil }) { | ||
| return .mssql | ||
| } | ||
| if keywords["uid"] != nil || keywords["pwd"] != nil { | ||
| return .mysql | ||
| } | ||
| return nil | ||
|
Comment on lines
+83
to
+90
There was a problem hiding this comment.
When an appsettings entry uses the common SqlClient form Useful? React with 👍 / 👎. |
||
| } | ||
|
|
||
| private static func first(_ keywords: [String: String], _ names: [String]) -> String? { | ||
| for name in names { | ||
| if let value = keywords[name] { | ||
| return value | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| private static func splitHostPort(_ value: String, type: DatabaseType) -> (host: String, port: Int?) { | ||
| let separator: Character = type == .mssql ? "," : ":" | ||
| guard let index = value.firstIndex(of: separator) else { | ||
| return (value, nil) | ||
| } | ||
| let head = String(value[value.startIndex..<index]) | ||
| let tail = String(value[value.index(after: index)...]) | ||
| guard let port = Int(tail) else { | ||
| return (value, nil) | ||
| } | ||
| return (head, port) | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an ADO.NET connection-string value contains a semicolon inside quotes, such as
Password="pa;ss", splitting blindly at every semicolon records the password as"paand discards the remainder. The candidate is still presented as having a password but cannot authenticate, so the keyword parser needs to recognize quoted or escaped delimiters.Useful? React with 👍 / 👎.