Repository navigation
fix(plugin-firebase): keep a leading combining mark in request paths - #4040
Merged
Merged
Conversation
datlechin
enabled auto-merge (squash)
November 4, 2026 11:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\u{FE0F}general) no longer runs againstgeneral.documentId,updateMask) that start with a mark read back whole.{in a path is escaped, so a QUERY path is never read as its JSON body./split in the Firebase core goes per scalar: RTDB paths and URLs, Firestore paths and document names, collection group targets,__name__checks in the driver, IN lists.FirebaseStatement.parse), soPUT \u{FE0F} nullis destructive, as the driver runs it. The app linksTableProFirebaseCorefor this, as it does the Weaviate and Qdrant cores..priorityand other.keys as metadata and unwraps.value, as the Realtime Database stores JSON, soPUT users {".priority": 1}ranks with DELETE.Test plan
FirebaseStatementTests(TableProFirebaseCoreTests): round trip of names with leading combining marks, variation selectors, prepend characters, ZWJ and BOM, query items, QUERY paths, update masks, IN lists, Firestore and RTDB paths and request URLs. Fails onmain.QueryClassifierNonSqlTests: the classifier on the same names, and metadata-only bodies.ExternalStatementGateTests: those writes are refused where deletes are. Fail onmain.