Repository navigation
feat(linux): edit query results that read one table with its key - #4055
Merged
Merged
Conversation
…fter an unknown outcome
… asked query after a discard
datlechin
enabled auto-merge (squash)
November 5, 2026 09:25
…-results # Conflicts: # core/docs/decisions/README.md # linux/crates/app/src/ui/workspace/workspace_tabs.rs # linux/docs/decisions/README.md
…-results # Conflicts: # linux/docs/decisions/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResultColumn::origin,sql_syntax::source_table, andedit::{result_source, result_target, parsed_origins, value_for_column}decide editability for every app.SHOW CREATE TABLE.sqlite3_column_*_name.dm_exec_describe_first_result_set.cell_editabilitytest updated).Deliberately not fixed here
TIMESTAMPin the session's zone. A row keyed on one stays read-only, and a result holding one offers no Duplicate Row. Reading the instant needs the session's zone, a change to the MySQL editor's decoding.extra_float_digits,DateStyleand the like shape that text. Typed reads in the editor would lift both.Test plan
source_tableshapes and refusals;result_targetkey coverage, renamed, duplicated and computed columns, and catalog drift.*, alias, expression, view, temporary table, another schema or database, and a user transaction. SQLite and DuckDB run file-backed; PostgreSQL, MySQL, MariaDB, SQL Server, ClickHouse and Cassandra run in docker.tablepro-coreresult_target and source_table, the SQLite and DuckDB suites, the origin unit tests of every driver, and the app's result editing, results pane, accelerator and close-choice tests pass.SELECT * FROM customersresult edits, saves, and shows the saved value after the run that follows the save; a join explains why it is read-only.Screenshots
Before, a typed value goes nowhere:
After, the change is pending with Save and Discard:
A join says why it is read-only: