Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .claude/rules/data-sync-storage.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ paths:
- "apple/Packages/TableProCore/Sources/TableProConnectionLibrary/RecentConnectionsLedger.swift"
- "apple/Packages/TableProCore/Sources/TableProSnowflakeCore/SnowflakeAccount.swift"
- "apple/Packages/TableProCore/Sources/TableProSnowflakeCore/SnowflakeTokenCache.swift"
- "apple/Packages/TableProCore/Sources/TableProAnalytics/AnalyticsHeartbeatService.swift"
- "apple/Packages/TableProCore/Sources/TableProTheme/ThemeFileFormat.swift"
- "apple/Packages/TableProCore/Sources/TableProTheme/ThemeDefinition.swift"
- "apple/Packages/TableProCore/Sources/TableProTheme/ThemeSlot.swift"
Expand Down
2 changes: 1 addition & 1 deletion apple/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ The architecture is in the area rules under `.claude/rules/`, and its invariants
| TableProOracle | `Packages/`, wraps a pinned fork of OracleNIO | Oracle wire protocol |
| Sparkle | SPM | Updates, EdDSA-signed |
| Yams | SPM | YAML for project folder import |
| posthog-ios | SPM | Usage data, `Core/Services/Telemetry`; a build sends nothing unless `POSTHOG_PROJECT_KEY` is set |
| posthog-ios | SPM | Usage data in both apps: `TablePro/Core/Services/Telemetry` and `TableProMobile/TableProMobile/Platform/Telemetry.swift`; only a Release build with `POSTHOG_PROJECT_KEY` set sends anything |
| swift-nio, swift-nio-ssl, zstd | SPM | The Kafka plugin's transport, TLS and zstd codec |
| swift-openapi-generator, swift-openapi-runtime, swift-openapi-urlsession | SPM, through `Packages/TableProMacCore` | `TableProCloudAPI`, the client generated from tablepro-cloud's `api/v2.json`, sending over `URLSession`; `scripts/update-cloud-api.sh` refreshes its copy and the entitlement test vectors |

Expand Down
3 changes: 2 additions & 1 deletion apple/Configs/Base.xcconfig
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ TABLEPRO_APP_BUNDLE_IDENTIFIER = com.TablePro
// Only the app target reads this, so a profile passed here never reaches a plugin or package target.
TABLEPRO_PROVISIONING_PROFILE =

// The PostHog project the macOS app sends usage data to. Empty sends nothing; a release sets it in Secrets.xcconfig.
// The PostHog project both apps send usage data to. Empty sends nothing; a release sets it in Secrets.xcconfig, and
// Debug.xcconfig empties it again.
POSTHOG_PROJECT_KEY =

#include? "Secrets.xcconfig"
3 changes: 3 additions & 0 deletions apple/Configs/Debug.xcconfig
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,6 @@ MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE
ONLY_ACTIVE_ARCH = YES
SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG $(inherited)
SWIFT_OPTIMIZATION_LEVEL = -Onone

// Local runs, tests, UI tests and previews never send to the production project, whatever Secrets.xcconfig sets.
POSTHOG_PROJECT_KEY =
6 changes: 2 additions & 4 deletions apple/Configs/Secrets.xcconfig.example
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@
// so nothing here ever reaches a commit. Every value is optional: Configs/Base.xcconfig
// includes this file with #include?, so the build works without it.

// Signs the iPhone and iPad app's usage report. Leave empty for local development.
ANALYTICS_HMAC_SECRET =

// The PostHog project usage data goes to. Leave empty: a build with a key sends to that project.
// The PostHog project usage data goes to. Leave empty: a Release build with a key sends to that project. Debug builds
// never carry it.
POSTHOG_PROJECT_KEY =

// Your Apple Developer team, for building under your own signing identity.
Expand Down
11 changes: 0 additions & 11 deletions apple/Packages/TableProCore/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ let package = Package(
.library(name: "TableProQuery", targets: ["TableProQuery"]),
.library(name: "TableProSyncTransport", targets: ["TableProSyncTransport"]),
.library(name: "TableProSync", targets: ["TableProSync"]),
.library(name: "TableProAnalytics", targets: ["TableProAnalytics"]),
.library(name: "TableProMSSQLCore", targets: ["TableProMSSQLCore"]),
.library(name: "TableProKerberos", targets: ["TableProKerberos"]),
.library(name: "TableProTeradataCore", targets: ["TableProTeradataCore"]),
Expand Down Expand Up @@ -150,11 +149,6 @@ let package = Package(
dependencies: ["TableProSyncTransport", "TableProModels", "TableProCoreTypes", "TableProConnectionLibrary"],
path: "Sources/TableProSync"
),
.target(
name: "TableProAnalytics",
dependencies: [],
path: "Sources/TableProAnalytics"
),
.target(
name: "TableProMSSQLCore",
dependencies: ["TableProCoreTypes", "TableProSQLGrammar", "TableProSQLQuoting"],
Expand Down Expand Up @@ -535,11 +529,6 @@ let package = Package(
path: "Tests/TableProAutocompleteTests",
swiftSettings: pluginCoreSettings
),
.testTarget(
name: "TableProAnalyticsTests",
dependencies: ["TableProAnalytics"],
path: "Tests/TableProAnalyticsTests"
),
.testTarget(
name: "TableProMSSQLCoreTests",
dependencies: ["TableProMSSQLCore", "TableProSQLGrammar", "TableProTestSupport"],
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading