Repository navigation
feat(postgresql): show server notices with each statement's result - #4061
Merged
Merged
Conversation
…notices # Conflicts: # core/crates/drivers/postgres/src/editor/mod.rs # core/crates/drivers/postgres/src/editor/run.rs
datlechin
enabled auto-merge
November 6, 2026 03:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RAISE NOTICE,WARNING,INFO,VACUUM VERBOSE, "does not exist, skipping") show with the statement's result in the Output view, as psql prints them,DETAILandHINTincluded. Covers PostgreSQL, PGlite, Redshift, CockroachDB and KingbaseES.PRINToutput acrossSET STATISTICS XML OFF.NoticeLimitReachedevent. A row-limitedSELECTkeeps the notices raised at its cursor'sDECLAREand closingCOMMIT.SelectorBar). Copy and Select All reach the Messages text.ServerOutputCaptureTests.failureStillReadsTheOutputandcancellationReadsNothing(nowcancellationReadsNothingAfter) count the read before the statement;QueryPlanPresentationTests.modesAreTitledcounts the new Output mode.Test plan
LibPQNoticeOutputTests,ServerOutputCaptureTests(earlier output discarded, Stop during the read),BatchStatementRunTests(commit output, read before the rollback),FetchAllQueryTaskTests.fetchAllReplacesTheOutput,QueryPlanPresentationTests(Output for parsed and raw plans),OracleServerOutputPendingTests, corenotice_queueandsession_coreunit tests, PostgreSQL editor-session integration tests (limit,DECLAREwarning, cursorCOMMITnotice), WindowsRunMessagesTestsand InteropNoticeTests.PostgreSQLDriverTests(12),AllPluginsbuild, iOS build,TableProOraclepackage tests, core unit and Docker integration tests (29), Windows solution build with Interop and App.Model tests.apple/scripts/probes/check-postgresql-notices.shagainst PostgreSQL 17: 7 of 7.Docs: TableProApp/docs#183
Discussion: #4060