Repository navigation
fix: repair main after the Linux merges - #4065
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new_connection_tls, the mode fix(core): start a new connection on the TLS mode the engine's own client uses #4051 madeTlsFormState::newtake. feat(linux): connection URLs and Unix sockets for PostgreSQL and MySQL #4048's call sites still passed the capabilities, which broke the app build on main.follow_tls_defaultresets a mode the new driver does not offer, the same rule the form already applies.ConnectionDraft: the merge of fix(core): start a new connection on the TLS mode the engine's own client uses #4051 copiedApply's certificate lines intoFollowTlsDefault, whereurlis out of scope (CS0103 on both Windows jobs).Applykeeps them.Core (Windows x64), run 42151126358).Test plan
linux / Fast checkswith E0308 inconnect_dialog/mod.rsandcore / Core (Windows x64)inrelay::tests::a_failed_open_is_kept_for_the_connect_to_report.windows / Windows (Arm64)failed with CS0103 inConnectionDraft.cs.cargo clippy -p tablepro --all-targets -- -D warningspasses in the Linux dev container;TablePro.App.Model.Testscompiles on macOS.