Repository navigation
feat: add a keyboard shortcut for Export Results - #4066
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exportResultsshortcut. The Actions menu shows it too, and the data file window answers it.export, so existing bindings keep working.AppCommandsbroadcast that only the key window answered. Removes the broadcast andKeyWindowCommandSubscription.sink(_:whileKey:), which no longer has a caller.TableProTests/Core/Menu/ChromeSnapshot.json, which nothing has read since test: rewrite the test suite, test plans and CI #3412.win.export-resultson Ctrl+Shift+E exports what the tab in front shows (table rows, the editor's shown result, a key's entries), or says "Nothing to export". It is listed in the shortcuts dialog, the editor menu, and the grid and browse menus.Test plan
MainMenuShortcutCoverageTests.exportResultsLivesUnderExportandreboundExportResultsApplies,ShortcutUniquenessTests.exportCommandsAreSeparateRows,CommandActionsDispatchTests.gridExportResultsReachesItsOwnWindow,MainWindowToolbarShortcutHintTests.restorePreviousValuesFollowsItsBinding,DatabaseTreeMenuSpecTests.containerExportShowsNoShortcut.ExportUITests.testExportingQueryResultsFromTheKeyboardWritesACSVFile.itemWithoutShortcutHasNoKeyEquivalentuses the debugger's Stop item, since Restore Previous Values now carries a shortcut.windowThatIsNotKeyDoesNotRunis removed with the API it covered.workspace/tests/shell.rs,editor/tests.rs,key_tab/tests.rsandbrowse_tab/layout.rs; extendedbrowse_buttons_announce_their_keys,the_cell_menu_shows_the_cell_keysand the workspace action test.Screenshots
macOS, File > Export, before and after:
macOS, Settings > Keyboard filtered to "Export", before and after:
Linux, Keyboard Shortcuts, before and after:
Linux, the SQL editor's menu, before and after:
Linux, Ctrl+Shift+E after a query opens Export Rows on its result:
Fixes #4063