Skip to content

feat: add a keyboard shortcut for Export Results - #4066

Merged
datlechin merged 4 commits into
mainfrom
feat/export-results-shortcut
Nov 6, 2026
Merged

datlechin merged 4 commits into
mainfrom
feat/export-results-shortcut

Conversation

@datlechin

@datlechin datlechin commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Summary

  • macOS: File > Export > Export Results… gets ⌥⇧⌘E, a new rebindable exportResults shortcut. The Actions menu shows it too, and the data file window answers it.
  • macOS: Settings > Keyboard lists "Export Tables" (was "Export") and "Export Results". The stored key stays export, so existing bindings keep working.
  • macOS: the grid's Export Results… calls its own window instead of an AppCommands broadcast that only the key window answered. Removes the broadcast and KeyWindowCommandSubscription.sink(_:whileKey:), which no longer has a caller.
  • macOS: a database or schema's Export… in the sidebar no longer shows ⇧⌘E. That key runs Export Tables, which exports the selected tables, not the container.
  • macOS: the Restore Previous Values toolbar item shows the binding set for it in Settings.
  • macOS: deletes TableProTests/Core/Menu/ChromeSnapshot.json, which nothing has read since test: rewrite the test suite, test plans and CI #3412.
  • Linux: win.export-results on Ctrl+Shift+E exports what the tab in front shows (table rows, the editor's shown result, a key's entries), or says "Nothing to export". It is listed in the shortcuts dialog, the editor menu, and the grid and browse menus.

Test plan

  • New, failing on main: MainMenuShortcutCoverageTests.exportResultsLivesUnderExport and reboundExportResultsApplies, ShortcutUniquenessTests.exportCommandsAreSeparateRows, CommandActionsDispatchTests.gridExportResultsReachesItsOwnWindow, MainWindowToolbarShortcutHintTests.restorePreviousValuesFollowsItsBinding, DatabaseTreeMenuSpecTests.containerExportShowsNoShortcut.
  • New UI flow: ExportUITests.testExportingQueryResultsFromTheKeyboardWritesACSVFile.
  • Changed: itemWithoutShortcutHasNoKeyEquivalent uses the debugger's Stop item, since Restore Previous Values now carries a shortcut. windowThatIsNotKeyDoesNotRun is removed with the API it covered.
  • Linux: new tests in workspace/tests/shell.rs, editor/tests.rs, key_tab/tests.rs and browse_tab/layout.rs; extended browse_buttons_announce_their_keys, the_cell_menu_shows_the_cell_keys and the workspace action test.

Screenshots

macOS, File > Export, before and after:

macOS File > Export before
macOS File > Export after
macOS File > Export after, dark

macOS, Settings > Keyboard filtered to "Export", before and after:

macOS Keyboard settings before
macOS Keyboard settings after
macOS Keyboard settings after, dark

Linux, Keyboard Shortcuts, before and after:

Linux shortcuts before
Linux shortcuts after
Linux shortcuts after, dark

Linux, the SQL editor's menu, before and after:

Linux editor menu before
Linux editor menu after
Linux editor menu after, dark

Linux, Ctrl+Shift+E after a query opens Export Rows on its result:

Linux Ctrl+Shift+E

Fixes #4063

@datlechin
datlechin added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 2567b04 Nov 6, 2026
31 checks passed
@datlechin
datlechin deleted the feat/export-results-shortcut branch November 6, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add shortcut to export results

1 participant