feat: restore previous session connections and add start-maximized option#332
Open
GabrielMalava wants to merge 4 commits into
Open
feat: restore previous session connections and add start-maximized option#332GabrielMalava wants to merge 4 commits into
GabrielMalava wants to merge 4 commits into
Conversation
… previous session.
… restoration, and adding a way for the user to open the system in fullscreen.
GabrielMalava
changed the title
Author
What
How
i18n
|
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| useEffect(() => { | ||
| if (autoConnectAttempted) return; | ||
| if (connections.length === 0) return; | ||
| autoConnectAttempted = true; |
There was a problem hiding this comment.
WARNING: autoConnectAttempted is set before checking the autoConnectLastConnection setting
If the user disables auto-connect (or it starts disabled), the flag is set to true anyway. If they later enable the setting in the same app session, the effect re-runs but is blocked by the already-set flag, so auto-connect never executes.
Move autoConnectAttempted = true; to after the settings.autoConnectLastConnection === false check.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Overview
Files Reviewed (16 files)
Previously reported issue resolved: The Previous Review Summary (commit 3280977)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 3280977)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)
Files Reviewed (15 files)
Reviewed by kimi-k2.6-20260420 · Input: 43.6K · Output: 1.7K · Cached: 113.2K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.