chore(wiki): document Lingui plugin i18n#8
Open
NewtTheWolf wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Previous Review Summary (commit eca1cee)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit eca1cee)Status: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by kimi-k2.6-20260420 · Input: 21.3K · Output: 2.8K · Cached: 170.8K |
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
|
The host app now runs on Lingui. Update the plugin docs accordingly:
- usePluginTranslation reads the plugin's locales/<lang>.json (ICU {var};
legacy {{var}} still works), not an i18next-compatible translator.
- Add a "Translating your plugin" section to building-plugins.md covering the
locales/ folder, usage, and the en.json -> key fallback chain.
eca1cee to
eed7fda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The host app migrated from i18next to Lingui (see TabularisDB/tabularis#351). This updates the plugin author docs to match.
Changes
building-plugins.md/plugins.md—usePluginTranslation(pluginId)now reads the plugin's ownlocales/<lang>.json(ICU{var}placeholders; legacy i18next{{var}}still resolves), instead of being described as an "i18next-compatible translator".building-plugins.md— new "Translating your plugin" section: thelocales/folder shipped by the--with-uiscaffold, how to read keys withusePluginTranslation, and theen.json → keyfallback chain.Docs-only; no code changes.
🤖 Generated with Claude Code