test(utils): implement add deterministic unit coverage for SWRCache (#357)#552
Open
Neziahtech wants to merge 2 commits into
Open
test(utils): implement add deterministic unit coverage for SWRCache (#357)#552Neziahtech wants to merge 2 commits into
Neziahtech wants to merge 2 commits into
Conversation
|
@Neziahtech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #357
Summary
SWRCacheinsrc/utils/swrCache.tshad no test file despite being a shared concurrency-sensitive utility. This PR adds a deterministic unit suite covering all five behavioral paths — fresh hit, stale hit with background revalidation, cache miss, revalidation error, and concurrent miss coalescing — using fake timers so no real delays are introduced.Files Changed
src/utils/swrCache.test.tssrc/utils/swrCache.tsSWRCacheclass and public methods; no logic changesTest Cases
Fresh hit
Stale hit + background revalidation
Cache miss
Revalidation error
console.error(spy asserted)Concurrent miss coalescing
Implementation Notes
jest.useFakeTimers) control all TTL and staleness boundaries — nosetTimeout/Date.nowreal delays anywhere in the suite.afterEachto prevent bleed between tests.swrCache.tsbeyond comments.Test Output
Coverage
src/utils/swrCache.tsChecklist
src/utils/swrCache.test.tscreatedSWRCacheand shared test helpersnpm run lintcleannpm run test:cipassingswrCache.ts