fix(solid-query): fetch on status-only reads#10838
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughReads of status/error/fetch-related properties on Solid Query results now force the Solid resource to be read, starting observer subscriptions and fetches for curried ChangesStatus Field Resource Tracking
Devtools stylesheet nonce handling
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Validation
(fails in this environment due pre-existing Vitest issue: TypeError: filename must be a file URL object, file URL string, or absolute path string. Received 'file:///@solid-refresh' and related
oot.eslint.config.js typecheck parser errors)
Summary by CodeRabbit
Bug Fixes
Tests
queryOptionswhen accessing status- or resource-related fields.Chores