fix(react-query): enforce TData consistency when select is not used#10844
fix(react-query): enforce TData consistency when select is not used#10844raashish1601 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR refactors ChangesuseQuery Select Option Type Safety
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
eact-query that enforce TData extends TQueryFnData when select is not provided.
Validation
ode ../../node_modules/typescript59/lib/tsc.js --pretty false --noEmit --strict --skipLibCheck --moduleResolution bundler --module ESNext --target ES2020 --jsx react-jsx src/useQuery.ts src/tests/useQuery.test-d.tsx
Summary by CodeRabbit
Tests
useQueryto ensure type compatibility with theselectparameter.Chores
useQueryto better distinguish between uses with and without theselectparameter.